Fix OSD level animation lag when using gesture volume control (#13338)

* Fix jerky level animation for small value changes

Fix jerky level animation for small value changes, if level value changes by less than 0.4 do it using new fast constant, set it to zero for now.

the 0.4 is kind of hardcoded as the I wanted the brightness (that jumps by 0.4 on my system) to have the 100ms level animation and all below it 0ms.

* Fix throttling OSD updates for gesture volume change

throttling OSD manager show function calls to prevent event flooding when using gestures for volume control, which too was contributing to some choppiness.

* Update Clutter animation to linear

Updates Clutter animation to linear to make is smooth and lower burstiness of animation.

* passed time arg to _set_volume which I forgot

* add separate level func for gesture

* update clean and minimal code

* gesture: add polling const and UI touchups

add polling const, reset last_time to 0 in begin() and show final volume state after gesture end.

* update: fix indentation

code had auto indented because of editor.

Author: screem02

js/ui/gestures/actions.js

@@ -8,6 +8,8 @@ const Magnifier = imports.ui.magnifier;
 
 const touchpad_settings = new  Gio.Settings({ schema_id: "org.cinnamon.desktop.peripherals.touchpad" });
 
+const CONTINUOUS_ACTION_POLL_INTERVAL = 50 * 1000;
+
 var make_action = (settings, definition, device) => {
     var threshold = 100;
 
@@ -320,9 +322,12 @@ var VolumeAction = class extends BaseAction {
             this.max_volume = mixer.get_vol_max_norm();
 
         this.pct_step = Math.ceil(this.max_volume / 100);
+
+        this.last_time = 0;
+        this.poll_interval = CONTINUOUS_ACTION_POLL_INTERVAL;
     }
 
-    _set_volume(up, percentage) {
+    _set_volume(up, percentage, time) {
         const sink = mixer.get_default_sink();
 
         if (sink == null) {
@@ -356,7 +361,12 @@ var VolumeAction = class extends BaseAction {
             sink.change_is_muted(false);
         }
 
+        if (time < (this.last_time + this.poll_interval)) {
+            return;
+        }
+
         Main.osdWindowManager.show(-1, this._get_volume_icon(int_pct, false), null, int_pct, false);
+        this.last_time = time;
     }
 
     _toggle_muted() {
@@ -395,16 +405,17 @@ var VolumeAction = class extends BaseAction {
             return;
         };
 
+        this.last_time = 0;
         this.update(direction, percentage, time);
     }
 
     update(direction, percentage, time) {
         if (this.definition.action === "VOLUME_UP") {
-            this._set_volume(true, percentage);
+            this._set_volume(true, percentage, time);
         }
         else
         if (this.definition.action === "VOLUME_DOWN") {
-            this._set_volume(false, 100 - percentage);
+            this._set_volume(false, 100 - percentage, time);
         }
     }
 
@@ -417,6 +428,13 @@ var VolumeAction = class extends BaseAction {
         if (percentage < this.threshold) {
             return;
         }
+
+        var int_pct = Math.ceil(percentage);
+        if (this.definition.action === "VOLUME_DOWN") {
+            int_pct = 100 - int_pct;
+        }
+
+        Main.osdWindowManager.show(-1, this._get_volume_icon(int_pct), null, int_pct, false);
     }
 }
 
@@ -462,7 +480,7 @@ var ZoomAction = class extends BaseAction {
         super(definition, device, threshold);
         this.last_percentage = 0;
         this.last_time = 0;
-        this.poll_interval = 50 * 1000;
+        this.poll_interval = CONTINUOUS_ACTION_POLL_INTERVAL;
 
         if (definition.custom_value !== "") {
             try {