Skip to content

numlock state always remembered when changed #328

@RaychoRaykov

Description

@RaychoRaykov
 * csd version: 4.8.4+ulyssa
 * Distribution: Linux Mint 20.1
 * 64 bit

Issue

CSD writes to disk on every press of NumLock.

Steps to reproduce

Press the NumLock and watch the disk operation indicator.

Use sudo inotifywait -m -e modify -r /home/user/.config/dconf to watch the realtime modifications:

/home/user/.config/dconf/ MODIFY user.FRBRZ0
/home/user/.config/dconf/ MODIFY user.FRBRZ0

Expected behaviour

There is an option in dconf: '/org/cinnamon/settings-daemon/peripherals/keyboard/remember-numlock-state', which should be checked before writing to dconf. I can't see any change of CSD behaviour when this option is enabled or disabled.

The actual code from the source file csd-keyboard-manager.c Line: 162 is:

	if (numlock_state != manager->priv->old_state) {
		g_settings_set_enum (manager->priv->settings,
				     KEY_NUMLOCK_STATE,
				     numlock_state);
		manager->priv->old_state = numlock_state;
	}

Other information

The same behavior can be seen on previous versions of Linux Mint / Cinnamon.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions