Properly cancel periodic hooks when unloading a plugin

Author: linuxdaemon

cloudbot/plugin.py

@@ -173,10 +173,10 @@ def load_plugin(self, path):
         self.plugins[plugin.file_name] = plugin
 
         for periodic_hook in plugin.periodic:
-            asyncio.async(self._start_periodic(periodic_hook))
+            task = asyncio.async(self._start_periodic(periodic_hook))
+            plugin.tasks.append(task)
             self._log_hook(periodic_hook)
 
-
         # register commands
         for command_hook in plugin.commands:
             for alias in command_hook.aliases:
@@ -249,6 +249,9 @@ def unload_plugin(self, path):
         # get the loaded plugin
         plugin = self.plugins[file_name]
 
+        for task in plugin.tasks:
+            task.cancel()
+
         # unregister commands
         for command_hook in plugin.commands:
             for alias in command_hook.aliases:
@@ -502,6 +505,7 @@ def __init__(self, filepath, filename, title, code):
         :type filename: str
         :type code: object
         """
+        self.tasks = []
         self.file_path = filepath
         self.file_name = filename
         self.title = title