Merge pull request CloudBotIRC#178 from linuxdaemon/gonzobot+chan-log-error-handling

Handle possible errors in chan_log error logging

Author: edwardslabs

plugins/core/chan_log.py

@@ -16,35 +16,48 @@ def _dump_attrs(obj):
 def on_hook_end(error, launched_hook, launched_event, admin_log):
     should_broadcast = True
     if error is not None:
-        admin_log(
-            "Error occurred in {}.{}".format(launched_hook.plugin.title, launched_hook.function_name), should_broadcast
-        )
-
-        lines = traceback.format_exception(*error)
-        last_line = lines[-1]
-        admin_log(last_line, should_broadcast)
-        url = web.paste('\n'.join(lines))
-        admin_log("Traceback: " + url, should_broadcast)
-
-        lines = ["{} = {}".format(k, v) for k, v in _dump_attrs(launched_event)]
-        exc_type, exc, exc_tb = error
-
-        lines.append("")
-        lines.append("Error data:")
-        lines.extend("{} = {}".format(k, v) for k, v in _dump_attrs(exc))
-
-        if isinstance(exc, RequestException):
-            if exc.request is not None:
-                req = exc.request
-                lines.append("")
-                lines.append("Request Info:")
-                lines.extend("{} = {}".format(k, v) for k, v in _dump_attrs(req))
-
-            if exc.response is not None:
-                response = exc.response
-                lines.append("")
-                lines.append("Response Info:")
-                lines.extend("{} = {}".format(k, v) for k, v in _dump_attrs(response))
-
-        url = web.paste('\n'.join(lines))
-        admin_log("Event: " + url, should_broadcast)
+        messages = [
+            "Error occurred in {}.{}".format(launched_hook.plugin.title, launched_hook.function_name)
+        ]
+
+        try:
+            lines = traceback.format_exception(*error)
+            last_line = lines[-1]
+            messages.append(last_line.strip())
+        except Exception as e:
+            messages.append("Error occurred while formatting error {}: {}".format(type(e), e))
+        else:
+            try:
+                url = web.paste('\n'.join(lines))
+                messages.append("Traceback: " + url)
+            except Exception as e:
+                messages.append("Error occurred while gathering traceback {}: {}".format(type(e), e))
+
+        try:
+            lines = ["{} = {}".format(k, v) for k, v in _dump_attrs(launched_event)]
+            exc_type, exc, exc_tb = error
+
+            lines.append("")
+            lines.append("Error data:")
+            lines.extend("{} = {}".format(k, v) for k, v in _dump_attrs(exc))
+
+            if isinstance(exc, RequestException):
+                if exc.request is not None:
+                    req = exc.request
+                    lines.append("")
+                    lines.append("Request Info:")
+                    lines.extend("{} = {}".format(k, v) for k, v in _dump_attrs(req))
+
+                if exc.response is not None:
+                    response = exc.response
+                    lines.append("")
+                    lines.append("Response Info:")
+                    lines.extend("{} = {}".format(k, v) for k, v in _dump_attrs(response))
+
+            url = web.paste('\n'.join(lines))
+            messages.append("Event: " + url)
+        except Exception as e:
+            messages.append("Error occurred while gathering error data {}: {}".format(type(e), e))
+
+        for message in messages:
+            admin_log(message, should_broadcast)