Skip to content

Commit 87d052f

Browse files
committed
Added TODOs for future PRs
1 parent cbf936e commit 87d052f

3 files changed

Lines changed: 3 additions & 0 deletions

File tree

cloudbot/clients/irc.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,7 @@ def connect(self):
126126
self.bot.plugin_manager.launch(hook, Event(bot=self.bot, conn=self, hook=hook))
127127
for hook in self.bot.plugin_manager.connect_hooks
128128
]
129+
# TODO stop connecting if a connect hook fails?
129130
yield from asyncio.gather(*tasks)
130131

131132
def quit(self, reason=None):

cloudbot/plugin.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -565,6 +565,7 @@ def __init__(self, filepath, filename, title, code):
565565
self.file_path = filepath
566566
self.file_name = filename
567567
self.title = title
568+
# TODO clean up hook lists
568569
hooks = find_hooks(self, code)
569570
self.commands, self.regexes, self.raw_hooks, *hooks = hooks
570571
self.sieves, self.events, self.periodic, *hooks = hooks

plugins/cap.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ def on_cap(irc_paramlist, conn, bot, event):
7575
logger.info("New capabilities advertised: %s", irc_paramlist[-1])
7676
yield from handle_available_caps(conn, caplist, event, irc_paramlist, bot)
7777
elif subcmd == 'DEL':
78+
# TODO add hooks for CAP removal
7879
logger.info("Capabilities removed by server: %s", irc_paramlist[-1])
7980
server_caps = conn.memory.setdefault('server_caps', {})
8081
for cap in caplist:

0 commit comments

Comments
 (0)