Skip to content

Commit 013aaae

Browse files
author
Martin Belanger
committed
udev-rules: use systemd escape char (\x09) instead of \t (tab)
Signed-off-by: Martin Belanger <[email protected]>
1 parent 8198720 commit 013aaae

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

staslib/service.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -510,7 +510,7 @@ def _dc_removed(self):
510510
UDEV_RULE_OVERRIDE = r'''
511511
ACTION=="change", SUBSYSTEM=="fc", ENV{FC_EVENT}=="nvmediscovery", \
512512
ENV{NVMEFC_HOST_TRADDR}=="*", ENV{NVMEFC_TRADDR}=="*", \
513-
RUN+="%s --no-block start nvmf-connect@--transport=fc\t--traddr=$env{NVMEFC_TRADDR}\t--trsvcid=none\t--host-traddr=$env{NVMEFC_HOST_TRADDR}.service"
513+
RUN+="%s --no-block restart nvmf-connect@--device\x3dnone\x09--transport\x3dfc\x09--traddr\x3d$env{NVMEFC_TRADDR}\x09--trsvcid\x3dnone\x09--host-traddr\x3d$env{NVMEFC_HOST_TRADDR}.service"
514514
'''
515515

516516

@@ -864,10 +864,12 @@ def _nvme_cli_interop(self, udev_obj):
864864
return
865865

866866
# We need to invoke "nvme connect-all" using nvme-cli's [email protected]
867-
# NOTE: Eventually, we'll be able to drop --host-traddr and --host-iface from
867+
# NOTE 1: Eventually, we'll be able to drop --host-traddr and --host-iface from
868868
# the parameters passed to [email protected]. A fix was added to connect-all
869869
# to infer these two values from the device used to connect to the DC.
870870
# Ref: https://github.com/linux-nvme/nvme-cli/pull/1812
871+
#
872+
# NOTE 2:--transport, --traddr, and --trsvcid, not needed when using --device
871873
cnf = [
872874
('--device', udev_obj.sys_name),
873875
('--host-traddr', udev_obj.properties.get('NVME_HOST_TRADDR', None)),

0 commit comments

Comments
 (0)