From 38cef3949aa3c4aad7e1baa88c7175bfa2d75ac9 Mon Sep 17 00:00:00 2001 From: Martin George Date: Thu, 19 Mar 2026 16:31:55 +0530 Subject: [PATCH] fabrics: permit bi-auth with secure concat TLS Turns out it is not just uni-auth that is supported with secure channel concat TLS but bi-auth as well. Earlier interpretation of the NVMe spec on this topic was wrong as discussed recently in the NVMe upstream mailing list at https://lore.kernel.org/linux-nvme/c60d58ae-84c6-49a1-b850-e23e12e7be45@suse.de/T/#t. So permit the same now in userspace. Fixes: 5fdc1313dc2c ("fabrics: add error if dhchap-ctrl-secret is specified with --concat") Signed-off-by: Martin George --- libnvme/src/nvme/fabrics.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/libnvme/src/nvme/fabrics.c b/libnvme/src/nvme/fabrics.c index c659b23ff6..0996278f05 100644 --- a/libnvme/src/nvme/fabrics.c +++ b/libnvme/src/nvme/fabrics.c @@ -725,11 +725,6 @@ static int build_options(nvme_host_t h, nvme_ctrl_t c, char **argstr) return -ENVME_CONNECT_INVAL; } - if (cfg->concat && ctrlkey) { - nvme_msg(h->ctx, LOG_ERR, "cannot specify [--dhchap-ctrl-secret | -C] with --concat\n"); - return -ENVME_CONNECT_INVAL; - } - if (cfg->tls) { ret = __nvme_import_keys_from_config(h, c, &keyring_id, &key_id);