From eb79b99b9db8ac5e5a506d2c8888b59a2b4be3d2 Mon Sep 17 00:00:00 2001 From: Dennis Maisenbacher Date: Tue, 30 Sep 2025 12:21:53 +0200 Subject: [PATCH 1/2] CI: checkout commit that triggered the workflow Until now we always checked out the default branch. Since we now allow workflow dispatches on forks this does not make sense anymore, and we should rather checkout the commit that triggered the workflow. Signed-off-by: Dennis Maisenbacher --- .github/workflows/run-nightly-tests.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/run-nightly-tests.yml b/.github/workflows/run-nightly-tests.yml index fb949b225f..12f59c88d8 100644 --- a/.github/workflows/run-nightly-tests.yml +++ b/.github/workflows/run-nightly-tests.yml @@ -51,6 +51,7 @@ jobs: git clone https://github.com/${{ github.repository }} nvme-cli cd nvme-cli + git checkout ${{ github.sha }} scripts/build.sh -b release -c gcc sudo meson install -C .build-ci sudo ldconfig /usr/local/lib64 @@ -86,7 +87,9 @@ jobs: uname -a PIPX_BIN_DIR=/usr/local/bin pipx install nose2 --force git clone https://github.com/${{ github.repository }} /nvme-cli + git config --global --add safe.directory /nvme-cli cd /nvme-cli + git checkout ${{ github.sha }} scripts/build.sh -b release -c gcc CONTROLLER=$(echo "${BDEV0}" | sed 's/n[0-9]*$//') cat > tests/config.json << EOJ From c9e27a0c4a77a1b482f126950411eb835bb18c82 Mon Sep 17 00:00:00 2001 From: Dennis Maisenbacher Date: Tue, 30 Sep 2025 12:22:34 +0200 Subject: [PATCH 2/2] CI: continue independent test cases on previous failure We want to continue running the nvme-cli test cases even when the blktests fail. Signed-off-by: Dennis Maisenbacher --- .github/workflows/run-nightly-tests.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/run-nightly-tests.yml b/.github/workflows/run-nightly-tests.yml index 12f59c88d8..2bde990081 100644 --- a/.github/workflows/run-nightly-tests.yml +++ b/.github/workflows/run-nightly-tests.yml @@ -17,6 +17,7 @@ jobs: #We don't have to build the kernel here, as we have a cron job running on #the k8s cluster that builds the linus-master target nightly. - name: Run blktests in VM + id: blktests uses: ./.github/actions/kubevirt-action with: kernel_version: linus-master @@ -73,6 +74,7 @@ jobs: EF sudo ./check nvme md/001 - name: Run nvme-cli tests in VM + if: success() || steps.blktests.conclusion == 'failure' uses: ./.github/actions/kubevirt-action with: kernel_version: linus-master