build warnings in sandisk

[dwsuse]

[   23s] In function ‘memset’,
[   23s]     inlined from ‘sndk_get_serial_name’ at ../plugins/sandisk/sandisk-utils.c:813:2,
[   23s]     inlined from ‘sndk_vs_internal_fw_log’ at ../plugins/sandisk/sandisk-nvme.c:479:9:
[   23s] /usr/include/bits/string_fortified.h:59:10: warning: ‘__builtin___memset_chk’ writing 4096 bytes into a region of size 4092 overflows the destination [-Wstringop-overflow=]
[   23s]    59 |   return __builtin___memset_chk (__dest, __ch, __len,
[   23s]       |          ^
[   23s] In function ‘snprintf’,
[   23s]     inlined from ‘sndk_get_serial_name’ at ../plugins/sandisk/sandisk-utils.c:828:12,
[   23s]     inlined from ‘sndk_vs_internal_fw_log’ at ../plugins/sandisk/sandisk-nvme.c:479:9:
[   23s] /usr/include/bits/stdio2.h:68:10: warning: ‘__builtin___snprintf_chk’ specified bound 4096 exceeds destination size 4092 [-Wstringop-overflow=]
[   23s]    68 |   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
[   23s]       |          ^

Build fails on tumbleweed/factory.

[igaw]

Let's get the fedora and tumbleweed build running....

#3143

We might also need to add a build with FORTIFIED enabled.

[igaw]

@jeff-lien-sndk could you have look at this one too? thanks!

[jeff-lien-sndk]

@igaw Yea, I'll take a look and fix.

[jeff-lien-sndk]

@igaw I believe I have a fix for this. Is there a way to force a build on tumbleweed to verify it? Short of pushing the change and creating a new PR?

[igaw]

Yes, you can run it inside the tumbleweed container locally:

sudo docker run --rm -it --name nvme-cli-debug ghcr.io/linux-nvme/tumbleweed:latest  bash

git clone https://github.com/linux-nvme/nvme-cli.git
cd nvme-cli

export CFLAGS="-O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 \
                  -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables \
                  -fstack-clash-protection -Werror=return-type -flto=auto -g"
export CXXFLAGS="$CFLAGS"
export LDFLAGS="-flto=auto"

./script/build.sh -b release -c gcc

Or just create a PR :)

[jeff-lien-sndk]

I just created PR #3163 for this issue.

[igaw]

Merged, thanks!