blktests nvme/046 failure

[kawasaki]

When I tested the latest libnvme and nvme-cli, I observed blktests test case nvme/046 failed.

nvme/046 => nvme0n1 (basic test for unprivileged passthrough on /dev/ngX) [failed]
    runtime  0.248s  ...  0.375s
    --- tests/nvme/046.out      2023-04-06 10:11:07.925670528 +0900
    +++ /home/shin/Blktests/blktests/results/nvme0n1/nvme/046.out.bad   2026-02-20 16:35:18.834545847 +0900
    @@ -1,2 +1,5 @@
     Running nvme/046
    +Error: io-passthru read failed
    +Error: id-ns failed
    +Error: id-ctrl failed
     Test complete

The failure was not observed with older libnvme/nvme-cli (1.15/2.15). I tried to bisect pinning libnvme version to the git hash d65b44cd. The failure was observed with nvme-cli git hash 4fb93ad, and was not observed with git hash 77b6d0c. There are some commits between these commits, but they all look failing to build nvme-cli.

I guess and hope that libnvme/nvme-cli experts' knowledge to resolve this failure quicker than my effort.

[igaw]

oh, I haven't seen those because our CI build is not running this test:

[76](https://github.com/linux-nvme/nvme-cli/actions/runs/22210145578/job/64242490811#step:3:2380)
nvme/046 => nvme1n1 (basic test for unprivileged passthrough on /dev/ngX)
nvme/046 => nvme1n1 (basic test for unprivileged passthrough on /dev/ngX) [not run]
    valid NORMAL_USER is not specified

https://github.com/linux-nvme/nvme-cli/actions/runs/22210145578/job/64242490811

[ikegami-t]

The older version (commit: 77b6d0c) can handle the device: /dev/ng0n1 but the latest version failed as the error: Invalid argument.

tokunori@tokunori-X570-Taichi:~/nvme-cli$ nvme --version
nvme version 2.16 (git 2.16-1975-g77b6d0c)
libnvme version 1.16 (git 1.16)
tokunori@tokunori-X570-Taichi:~/nvme-cli$ sudo nvme io-passthru /dev/ng0n1 --opcode 2 --data-len 4096 --namespace-id -1 --read -s --dry-run
opcode       : 02
flags        : 00
rsvd1        : 0000
nsid         : ffffffff
cdw2         : 00000000
cdw3         : 00000000
data_len     : 00001000
metadata_len : 00000000
addr         : 5a89b07d6000
metadata     : 0
cdw10        : 00000000
cdw11        : 00000000
cdw12        : 00000000
cdw13        : 00000000
cdw14        : 00000000
cdw15        : 00000000
timeout_ms   : 00000000
tokunori@tokunori-X570-Taichi:~/nvme-cli$ sudo .build/nvme io-passthru /dev/ng0n1 --opcode 2 --data-len 4096 --namespace-id -1 --read -s --dry-run
/dev/ng0n1: Invalid argument
Usage: nvme io-passthru <device> [OPTIONS]

Send a user-defined IO command to the specified device via IOCTL passthrough,
return results.

Options:
  [  --verbose, -v ]                    --- Increase output verbosity
...
  [  --output-format-version=<NUM> ]    --- output format version: 1|2

[ikegami-t]

Seems currently only expected the device: /dev/nvmeX as direct device but not for the device: /dev/ngX.

static int __nvme_transport_handle_open_direct(struct nvme_transport_handle *hdl, const char *devname)
{
	struct nvme_passthru_cmd dummy = { 0 };
	_cleanup_free_ char *path = NULL;
	char *name = basename(devname);
	int ret, id, ns;
	bool c;

	hdl->type = NVME_TRANSPORT_HANDLE_TYPE_DIRECT;

	ret = sscanf(name, "nvme%dn%d", &id, &ns);
	if (ret != 1 && ret != 2)
		return -EINVAL;

[ikegami-t]

Note: Still failed the id-ctrl and show-topology commands on the older version (commit: 77b6d0c) with the device: /dev/ngX. (So the issue is not only for the latest version as existed on the older version on some commands.)

[ikegami-t]

Just pushed the PR: #3107 commit changes so can you test it? (Locall Locally it looks work for the io-passthru command.)
Note: Still the id-ctrl list-subsys and show-topology commands not fixed then will try to fix them separately.

(Added)
Note2: The device: /dev/nvme0 also failed on the io-passthru command but it works on the older version (commit: 77b6d0c) so will do investigate this also separately.

[igaw]

I've run manually the io-passthru commands they seem to work. Let me figure out how to configure blktests so I ran the full test with current head version of nvme-cli

test@localhost:/home/wagi/work/nvme-cli-upstream/.build-debian$ ./nvme io-passthru /dev/ng0n1 --opcode 2 --data-len 4096 --namespace-id 1 --read
IO Command Read is Success and result: 0x0
       0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f
0000: ca ac 05 00 00 10 00 00 d6 5a 60 e9 e5 c6 6a 5c ".........Z`...j\"
0010: 00 00 00 00 00 00 00 00 8e 0f 00 00 7d 25 28 14 "............}%(."
0020: 01 00 b0 cb 31 1c 29 e5 74 3e ce 2a 11 89 3e b8 "....1.).t>.*..>."
0030: 56 ad b6 49 9a cd 5d 14 3a 76 30 d0 ab 56 9c cc "V..I..].:v0..V.."
0040: a6 0a 66 e6 e5 84 60 54 4c 15 cc cc cb 09 c1 a8 "..f...`TL......."
0050: f2 1f 32 b3 b1 8e 21 fd 3e 35 fe 7f 7d 98 e2 a5 "..2...!.>5..}..."
0060: 62 b8 7c 3e cd 5c 84 63 c4 70 f9 7c 9a b9 08 c7 "b.|>.\.c.p.|...."
0070: 26 29 76 bb 67 16 8d 2a ea 99 6f 38 02 d0 95 f1 "&)v.g..*..o8...."
0080: f6 67 21 8c 8d 78 87 df ec cf 42 18 1b f1 0e bf ".g!..x....B....."
0090: e2 37 64 a4 a8 69 96 9e ce 07 a7 bc c3 5a a5 5d ".7d..i.......Z.]"
00a0: d2 50 cb 3b 82 11 ee c1 a4 a1 96 77 04 23 dc 83 ".P.;.......w.#.."
00b0: 76 f2 61 b3 86 34 ca 45 1a 94 f8 2a 8b 57 a6 c9 "v.a..4.E...*.W.."
00c0: c6 a6 78 12 bb ab 6f d3 8c 4d f1 24 76 57 df a6 "..x...o..M.$vW.."
00d0: 52 f4 69 37 31 03 4f 7a de 41 5b 5c a7 5a 2e 21 "R.i71.Oz.A[\.Z.!"
00e0: c2 69 16 9c 02 00 dd b5 84 d3 2c 38 05 00 ba 6b ".i........,8...k"
00f0: 46 3d 43 d4 07 00 97 21 ca 10 70 0c 0d 00 51 8d "F=C....!..p...Q."
0100: 16 5b db 86 0a 60 d0 e3 2c b6 b6 0d 15 c0 a0 c7 ".[...`..,......."
0110: 42 11 92 94 1f 20 71 ab 6e c7 48 a2 34 e0 11 73 "B.....q.n.H.4..s"
0120: 32 df 86 71 52 ff 24 1d 64 be 0d e3 a4 fe 49 3a "2..qR.$.d.....I:"
0130: 96 9d 94 54 f7 fd 6e 57 fa 5b a2 37 9c fc b8 91 "...T..nW.[.7...."
0140: e6 78 5f 09 67 78 70 62 cc f1 be 12 ce f0 e0 c4 ".x_.gxpb........"
0150: b2 6a 1e 1c 35 69 51 27 7e 5c dd 2e 03 5a 32 ec ".j..5iQ'~\...Z2."
0160: 22 ad 1f f0 38 10 78 b3 44 5a 3f e0 71 20 f0 66 ""...8.x.DZ?.q..f"
0170: 66 07 5f d0 aa 30 68 1a aa 61 9e b0 1c 51 58 81 "f._..0h..a...QX."
0180: 36 54 b6 0b 67 c7 ae 81 6c a8 6c 17 ce 8e 5d 03 "6T..g...l.l...]."
0190: a2 fc 22 23 35 56 0c 85 0e a5 8f 3a 03 e5 69 88 ".."#5V.....:..i."
01a0: 92 ef a4 97 5e 83 50 e1 24 df 49 2f bd 06 a1 c2 "....^.P.$.I/...."
01b0: b6 ce ee c6 1b 8a f1 a3 da ad 38 f6 d8 90 92 66 "..........8....f"
01c0: 06 a1 39 fd c0 9c 65 7e 0c 42 73 fa 81 39 cb fc "..9...e~.Bs..9.."
01d0: 12 e3 ac f7 42 d6 30 7b 1e 25 20 f2 c4 0f fc 77 "....B.0{.%.....w"
01e0: 82 e2 8a ca a2 ac 48 d4 04 c5 15 95 45 59 91 a8 "......H.....EY.."
01f0: 86 a7 a0 5f e8 05 da 7c 8a 6c b6 f4 2d 5f 6b 25 "..._...|.l..-_k%"
0200: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 "................"
*
1000:

test@localhost:/home/wagi/work/nvme-cli-upstream/.build-debian$ echo hello | ./nvme io-passthru /dev/ng0n1 --opcode 1 --data-len 4096 --namespace-id 1 --read
passthru: Permission denied

[igaw]

should work with the fix from #3107

nvme/046 => nvme0n1 (basic test for unprivileged passthrough on /dev/ngX) [passed]
    runtime  0.518s  ...  0.509s

Thanks @ikegami-t for the fix!

[kawasaki]

@ikegami-t @igaw Thank you for the quick fix!