./nvme reset /dev/nvme0n1 shows "Reset: Unknown error -15"

[yizhanglinux]

I tried the latest nvme-cli to do the nvme reset and nvme subsystem-reset on one nvme disk,
but it shows "Unknown error -15" when I use the NS device[1], but the previous version shows "Reset: Block device required"[2].

And also I think "Block device required" is misleading since we need put the char device /dev/nvme0 here.

[1]

# ./nvme --version
nvme version 3.0-a.1 (git 2.16-2216-ga57c1b3)
libnvme version 3.0-a.1 (git 2.16-2216-ga57c1b3)

# ./nvme reset /dev/nvme0n1
Reset: Unknown error -15

[2]

# nvme --version
nvme version 2.16 (git 2.16)
libnvme version 1.16.1 (git 1.16.1)
# nvme reset /dev/nvme0n1
Reset: Block device required

# nvme subsystem-reset /dev/nvme0n1
Subsystem-reset: Block device required

[keithbusch]

Eh, that's an unusual errno to return for this condition. It should be required to be not a block device, so ENOTBLK is a bit confusing, and you're trying to issue the reset on a block device. Try controller management handle, "/dev/nvme0", instead of the namespace handle.

[ikegami-t]

Just created the PR: #3075.

[igaw]

Just merged @ikegami-t's fix.