Skip to content

Commit fdbda0f

Browse files
committed
libnvme: change copy_range name to copy_range_f0
Change both the struct name and the init API names. Signed-off-by: Tokunori Ikegami <[email protected]>
1 parent b93b7e8 commit fdbda0f

4 files changed

Lines changed: 14 additions & 13 deletions

File tree

libnvme/src/nvme/cmds.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4383,7 +4383,7 @@ nvme_init_copy(struct nvme_passthru_cmd *cmd, __u32 nsid, __u64 sdlba,
43834383
data_len = nr * sizeof(struct nvme_copy_range_f3);
43844384
break;
43854385
default:
4386-
data_len = nr * sizeof(struct nvme_copy_range);
4386+
data_len = nr * sizeof(struct nvme_copy_range_f0);
43874387
break;
43884388
}
43894389

@@ -5252,7 +5252,7 @@ nvme_init_copy_range_elbt(__u8 *elbt, __u64 eilbrt)
52525252
}
52535253

52545254
/**
5255-
* nvme_init_copy_range() - Constructs a copy range structure
5255+
* nvme_init_copy_range_f0() - Constructs a copy range structure
52565256
* @copy: Copy range array
52575257
* @nlbs: Number of logical blocks
52585258
* @slbas: Starting LBA
@@ -5262,7 +5262,7 @@ nvme_init_copy_range_elbt(__u8 *elbt, __u64 eilbrt)
52625262
* @nr: Number of descriptors to construct
52635263
*/
52645264
static inline void
5265-
nvme_init_copy_range(struct nvme_copy_range *copy, __u16 *nlbs,
5265+
nvme_init_copy_range_f0(struct nvme_copy_range_f0 *copy, __u16 *nlbs,
52665266
__u64 *slbas, __u32 *elbts, __u32 *elbatms,
52675267
__u32 *elbats, __u16 nr)
52685268
{

libnvme/src/nvme/types.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6436,7 +6436,7 @@ struct nvme_dsm_range {
64366436
};
64376437

64386438
/**
6439-
* struct nvme_copy_range - Copy - Source Range Entries Descriptor Format
6439+
* struct nvme_copy_range_f0 - Copy - Source Range Entries Descriptor Format
64406440
* @rsvd0: Reserved
64416441
* @slba: Starting LBA
64426442
* @nlb: Number of Logical Blocks
@@ -6446,7 +6446,7 @@ struct nvme_dsm_range {
64466446
* @elbatm: Expected Logical Block Application Tag Mask
64476447
* @elbat: Expected Logical Block Application Tag
64486448
*/
6449-
struct nvme_copy_range {
6449+
struct nvme_copy_range_f0 {
64506450
__u8 rsvd0[8];
64516451
__le64 slba;
64526452
__le16 nlb;

libnvme/test/ioctl/misc.c

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -983,7 +983,7 @@ static void test_dsm(void)
983983
static void test_copy(void)
984984
{
985985
__u16 nr = TEST_COPY_NR, cev = 0, dspec = 0;
986-
int copy_size = sizeof(struct nvme_copy_range) * nr, err;
986+
int copy_size = sizeof(struct nvme_copy_range_f0) * nr, err;
987987
bool prinfor = false, prinfow = false, stcw = false,
988988
stcr = false, fua = false, lr = false;
989989
__u8 cetype = 0, dtype = 0, desfmt = 0xf;
@@ -993,7 +993,7 @@ static void test_copy(void)
993993
__u32 short_pi[TEST_COPY_NR] = { 0x1000, 0x20000000, 0x40000000 };
994994
__u32 elbatms[TEST_COPY_NR] = { 0x1ff, 0x3ff, 0x3ff };
995995
__u32 elbats[TEST_COPY_NR] = { 0x111, 0x222, 0x333 };
996-
__u8 expected_data[sizeof(struct nvme_copy_range) * TEST_COPY_NR] = {
996+
__u8 expected_data[sizeof(struct nvme_copy_range_f0) * TEST_COPY_NR] = {
997997
0, 0, 0, 0, 0, 0, 0, 0, 0, 0x10, 0, 0, 0, 0, 0, 0,
998998
0xa, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0x10, 0, 0x11, 1, 0xff, 1,
999999
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0x20, 0, 0, 0, 0,
@@ -1002,7 +1002,7 @@ static void test_copy(void)
10021002
0xc, 0, 0, 0, 0, 0, 0, 0, 0x40, 0, 0, 0, 0x33, 3, 0xff, 3
10031003
};
10041004

1005-
_cleanup_free_ struct nvme_copy_range *copy = NULL;
1005+
_cleanup_free_ struct nvme_copy_range_f0 *copy = NULL;
10061006

10071007
copy = calloc(1, copy_size);
10081008
check(copy, "copy: ENOMEM");
@@ -1017,13 +1017,14 @@ static void test_copy(void)
10171017
((dtype & 0xf) << 20) |
10181018
((prinfow & 0xf) << 26) |
10191019
((fua & 0x1) << 30) | ((lr & 0x1) << 31),
1020-
.data_len = nr * sizeof(struct nvme_copy_range),
1020+
.data_len = nr * sizeof(struct nvme_copy_range_f0),
10211021
.in_data = expected_data,
10221022
};
10231023
struct nvme_passthru_cmd cmd;
10241024

10251025
set_mock_io_cmds(&mock_io_cmd, 1);
1026-
nvme_init_copy_range(copy, nlbs, slbas, short_pi, elbatms, elbats, nr);
1026+
nvme_init_copy_range_f0(copy, nlbs, slbas, short_pi, elbatms, elbats,
1027+
nr);
10271028
nvme_init_copy(&cmd, TEST_NSID, sdlba, nr, desfmt,
10281029
prinfor, prinfow, cetype, dtype, stcw, stcr,
10291030
fua, lr, cev, dspec, (void *)copy);

nvme.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7770,7 +7770,7 @@ static int copy_cmd(int argc, char **argv, struct command *acmd, struct plugin *
77707770
__u32 elbats[256] = { 0 };
77717771

77727772
_cleanup_free_ union {
7773-
struct nvme_copy_range f0[256];
7773+
struct nvme_copy_range_f0 f0[256];
77747774
struct nvme_copy_range_f1 f1[256];
77757775
struct nvme_copy_range_f2 f2[256];
77767776
struct nvme_copy_range_f3 f3[256];
@@ -7922,8 +7922,8 @@ static int copy_cmd(int argc, char **argv, struct command *acmd, struct plugin *
79227922
eilbrts.long_pi, elbatms, elbats, nr);
79237923
break;
79247924
default:
7925-
nvme_init_copy_range(copy->f0, nlbs, slbas, eilbrts.short_pi,
7926-
elbatms, elbats, nr);
7925+
nvme_init_copy_range_f0(copy->f0, nlbs, slbas, eilbrts.short_pi,
7926+
elbatms, elbats, nr);
79277927
break;
79287928
}
79297929

0 commit comments

Comments
 (0)