Skip to content

Commit fa49a2f

Browse files
committed
libnvme: include main headers where possible
Unify the header includes. Use the libnvme.h or/and libnvme-mi.h everywhere instead indiviual headers. This makes the refactoring of the headers simpler (splitting them into smaller ones). Signed-off-by: Daniel Wagner <[email protected]>
1 parent 747030b commit fa49a2f

22 files changed

Lines changed: 50 additions & 54 deletions

File tree

libnvme/src/nvme/fabrics.c

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,15 +33,12 @@
3333
#include <ccan/array_size/array_size.h>
3434
#include <ccan/str/str.h>
3535

36+
#include <libnvme.h>
37+
3638
#include "cleanup.h"
37-
#include "fabrics.h"
38-
#include "linux.h"
39-
#include "ioctl.h"
40-
#include "nbft.h"
41-
#include "nvme/tree.h"
42-
#include "util.h"
4339
#include "log.h"
4440
#include "private.h"
41+
#include "util.h"
4542

4643
#define NVMF_HOSTID_SIZE 37
4744

libnvme/src/nvme/filters.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@
1010
#include <string.h>
1111
#include <dirent.h>
1212

13-
#include "filters.h"
13+
#include <libnvme.h>
14+
1415
#include "private.h"
1516

1617
int nvme_namespace_filter(const struct dirent *d)

libnvme/src/nvme/ioctl.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@
2626
#include <ccan/minmax/minmax.h>
2727
#include <ccan/endian/endian.h>
2828

29-
#include "ioctl.h"
29+
#include <libnvme.h>
30+
3031
#include "private.h"
3132

3233
static int nvme_verify_chr(struct nvme_transport_handle *hdl)

libnvme/src/nvme/json.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,10 @@
1414

1515
#include <json.h>
1616

17+
#include <libnvme.h>
18+
1719
#include "cleanup.h"
18-
#include "fabrics.h"
19-
#include "log.h"
2020
#include "private.h"
21-
#include "linux.h"
2221

2322
#define JSON_UPDATE_INT_OPTION(c, k, a, o) \
2423
if (!strcmp(# a, k ) && !c->a) c->a = json_object_get_int(o);

libnvme/src/nvme/linux.c

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,12 @@
3333

3434
#include <ccan/endian/endian.h>
3535

36+
#include <libnvme.h>
37+
38+
#include "crc32.h"
39+
#include "base64.h"
3640
#include "cleanup.h"
37-
#include "linux.h"
38-
#include "tree.h"
39-
#include "log.h"
4041
#include "private.h"
41-
#include "base64.h"
42-
#include "crc32.h"
4342

4443
void nvme_set_dry_run(struct nvme_global_ctx *ctx, bool enable)
4544
{

libnvme/src/nvme/log.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,12 @@
1515
#include <syslog.h>
1616
#include <unistd.h>
1717
#include <time.h>
18+
19+
#include <libnvme.h>
20+
21+
#include "cleanup.h"
1822
#define LOG_FUNCNAME 1
1923
#include "private.h"
20-
#include "log.h"
21-
#include "cleanup.h"
2224

2325
#ifndef LOG_CLOCK
2426
#define LOG_CLOCK CLOCK_MONOTONIC

libnvme/src/nvme/mi-mctp.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,10 @@
3434
#define MCTP_DBUS_IFACE_ENDPOINT "xyz.openbmc_project.MCTP.Endpoint"
3535
#endif
3636

37+
#include <libnvme.h>
38+
#include <libnvme-mi.h>
39+
3740
#include "private.h"
38-
#include "log.h"
39-
#include "mi.h"
4041

4142

4243
#if !defined(AF_MCTP)

libnvme/src/nvme/mi.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@
1717
#include <ccan/minmax/minmax.h>
1818
#include <ccan/endian/endian.h>
1919

20-
#include "log.h"
21-
#include "mi.h"
22-
#include "linux.h"
20+
#include <libnvme.h>
21+
#include <libnvme-mi.h>
22+
2323
#include "private.h"
2424

2525
#define NUM_ENABLES (256u)

libnvme/src/nvme/nbft.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@
1313
#include <arpa/inet.h>
1414
#include <ccan/endian/endian.h>
1515

16+
#include <libnvme.h>
17+
1618
#include "private.h"
17-
#include "nbft.h"
18-
#include "log.h"
1919

2020
#define MIN(a, b) (((a) < (b)) ? (a) : (b))
2121

libnvme/src/nvme/no-json.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* Authors: Daniel Wagner <[email protected]>
77
*/
88

9-
#include "tree.h"
9+
#include <libnvme.h>
1010

1111
#include <errno.h>
1212

0 commit comments

Comments
 (0)