Skip to content

Commit f9cd5c7

Browse files
committed
build: github workflow cleanups
- make the workflow a bit more consisten by using by using capital letters for the build jobs. - start all files with --- - codeql: update build configuration - revmove unused libnvme release workflow - use PyPi token instead of usernname/password Signed-off-by: Daniel Wagner <[email protected]>
1 parent 988da23 commit f9cd5c7

6 files changed

Lines changed: 15 additions & 37 deletions

File tree

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
name: build
2+
name: Build
33

44
on:
55
push:

.github/workflows/codeql.yml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
1-
# CodeQL build configuration for nvme-cli
2-
# Mostly based on auto-configuration with additions and tweaks for:
3-
# * meson install
4-
# * language detection
5-
name: "CodeQL"
1+
---
2+
name: CodeQL
63

74
on:
85
push:
@@ -65,7 +62,7 @@ jobs:
6562

6663
- name: meson build
6764
run: |
68-
meson setup --force-fallback-for=libnvme,json-c .build
65+
meson setup --force-fallback-for=json-c .build
6966
ninja -C .build
7067
7168
- name: Perform CodeQL Analysis

.github/workflows/coverage.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
name: coverage
2+
name: Codecov
33

44
on:
55
push:

.github/workflows/docs.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,12 @@ on:
66
branches: [master]
77
paths:
88
- Documentation/**
9+
- libnvme/doc/**
910
pull_request:
1011
branches: [master]
1112
paths:
1213
- Documentation/**
14+
- libnvme/doc/**
1315

1416
workflow_dispatch:
1517

.github/workflows/libnvme-cleanup-python.yml

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
1-
name: cleanup python
1+
---
2+
name: Cleanup Python dev releases
23

34
on:
45
workflow_dispatch:
56
inputs:
67
keep-last:
7-
description: "How many recent dev releases to keep"
8+
description: "Number of recent dev releases to keep"
89
required: false
910
default: "5"
1011
dry-run:
11-
description: "Only simulate the deletion (true/false)"
12+
description: "Only simulate deletions (true/false)"
1213
required: false
1314
default: "true"
1415

@@ -17,18 +18,18 @@ jobs:
1718
runs-on: ubuntu-latest
1819
environment: pypi
1920
steps:
21+
- name: Checkout repository
22+
uses: actions/checkout@v3
23+
2024
- name: Install pypi-cleanup
2125
run: pip install pypi-cleanup
2226

2327
- name: Run pypi-cleanup on TestPyPI
2428
env:
25-
PYPI_USERNAME: __token__
26-
PYPI_PASSWORD: ${{ secrets.TEST_PYPI_API_TOKEN }}
29+
PYPI_API_TOKEN: ${{ secrets.TEST_PYPI_API_TOKEN }}
2730
run: |
2831
cd libnvme
2932
pypi-cleanup \
30-
--username "$PYPI_USERNAME" \
31-
--password "$PYPI_PASSWORD" \
3233
--repository-url https://test.pypi.org/legacy/ \
3334
--package libnvme \
3435
--keep ${{ github.event.inputs.keep-last }} \

.github/workflows/libnvme-release.yml

Lines changed: 0 additions & 22 deletions
This file was deleted.

0 commit comments

Comments
 (0)