Moved O_BINARY definition into new nvme/fcntl.h

Author: bgoing-micron-oss

libnvme/src/meson.build

@@ -32,6 +32,7 @@ endif
 headers = [
     'nvme/accessors.h',
     'nvme/endian.h',
+    'nvme/fcntl.h',
     'nvme/filters.h',
     'nvme/ioctl.h',
     'nvme/lib-types.h',

libnvme/src/nvme/fcntl.h

@@ -0,0 +1,21 @@
+/* SPDX-License-Identifier: LGPL-2.1-or-later */
+/*
+ * This file is part of libnvme.
+ * Copyright (c) 2026 Micron Technology, Inc.
+ *
+ * Cross-platform compatibility for fcntl.h.
+ *
+ * Authors: Broc Going <[email protected]>
+ */
+#pragma once
+
+#include <fcntl.h>
+
+/*
+ * O_BINARY is required for Windows to avoid line ending translations.
+ * Define it as 0 on platforms where it is not defined so that it can be used
+ * but will have no effect.
+ */
+#ifndef O_BINARY
+#define O_BINARY 0
+#endif

plugins/ocp/ocp-nvme.c

@@ -17,6 +17,7 @@
 #include <time.h>
 
 #include <libnvme.h>
+#include <nvme/fcntl.h>
 
 #include "common.h"
 #include "logging.h"
@@ -1188,11 +1189,7 @@ static int get_telemetry_log_page_data(struct libnvme_transport_handle *hdl,
 	}
 	memset(hdr, 0, bs);
 
-#ifdef O_BINARY	/* required for Windows, not defined on Linux */
 	fd = open(output_file, O_WRONLY | O_CREAT | O_TRUNC | O_BINARY, 0666);
-#else
-	fd = open(output_file, O_WRONLY | O_CREAT | O_TRUNC, 0666);
-#endif
 	if (fd < 0) {
 		fprintf(stderr, "Failed to open output file %s: %s!\n",
 				output_file, libnvme_strerror(errno));