nvme-cli: Enhance format FNA detection

Always check the format attributes to verify if the controller will
apply the format to all namespaces, or if they can be individually
formatted. This is used to properly warn of the implications from sending
this command.

Signed-off-by: Keith Busch <[email protected]>

Author: Keith Busch

nvme.c

@@ -3580,6 +3580,7 @@ static int format(int argc, char **argv, struct command *cmd, struct plugin *plu
 	const char *bs = "target block size";
 	const char *force = "The \"I know what I'm doing\" flag, skip confirmation before sending command";
 	struct nvme_id_ns ns;
+	struct nvme_id_ctrl ctrl;
 	int err, fd, i;
 	__u8 prev_lbaf = 0;
 	__u8 lbads = 0;
@@ -3644,34 +3645,37 @@ static int format(int argc, char **argv, struct command *cmd, struct plugin *plu
 		}
 	}
 
-	if (S_ISBLK(nvme_stat.st_mode)) {
+	memset(&ctrl, 0, sizeof (struct nvme_id_ctrl));
+	err = nvme_identify_ctrl(fd, &ctrl);
+	if (err) {
+		perror("identify-ctrl");
+		goto close_fd;
+	}
+
+	if ((ctrl.fna & 1) == 1) {
+		/*
+		 * FNA bit 0 set to 1: all namespaces ... shall be configured with the same
+		 * attributes and a format (excluding secure erase) of any namespace results in a
+		 * format of all namespaces.
+		 */
+		cfg.namespace_id = NVME_NSID_ALL;
+	} else if (S_ISBLK(nvme_stat.st_mode)) {
 		cfg.namespace_id = get_nsid(fd);
 		if (cfg.namespace_id == 0) {
 			err = -EINVAL;
 			goto close_fd;
 		}
-	} else if (cfg.namespace_id == 0) {
-		struct nvme_id_ctrl ctrl;
+	}
 
-		memset(&ctrl, 0, sizeof (struct nvme_id_ctrl));
-		err = nvme_identify_ctrl(fd, &ctrl);
-		if (err) {
-			perror("identify-ctrl");
-			goto close_fd;
-		}
-		if ((ctrl.fna & 1) == 1) {
-			/*
-			 * FNA bit 0 set to 1: all namespaces ... shall be configured with the same
-			 * attributes and a format (excluding secure erase) of any namespace results in a
-			 * format of all namespaces.
-			 */
-			cfg.namespace_id = NVME_NSID_ALL;
-		} else {
-			fprintf(stderr, "Invalid namespace ID, specify a namespace to format or use '-n 0xffffffff' to format all namespaces on this controller.\n");
-			err = -EINVAL;
-			goto close_fd;
-		}
+	if (cfg.namespace_id == 0) {
+		fprintf(stderr,
+			"Invalid namespace ID, "
+			"specify a namespace to format or use '-n 0xffffffff' "
+			"to format all namespaces on this controller.\n");
+		err = -EINVAL;
+		goto close_fd;
 	}
+
 	if (cfg.namespace_id != NVME_NSID_ALL) {
 		err = nvme_identify_ns(fd, cfg.namespace_id, 0, &ns);
 		if (err) {
@@ -3734,8 +3738,9 @@ static int format(int argc, char **argv, struct command *cmd, struct plugin *plu
 	}
 
 	if (!cfg.force) {
-		fprintf(stderr, "You are about to format %s, namespace %#x.\n",
-			devicename, cfg.namespace_id);
+		fprintf(stderr, "You are about to format %s, namespace %#x%s.\n",
+			devicename, cfg.namespace_id,
+			cfg.namespace_id == NVME_NSID_ALL ? "(ALL namespaces)" : "");
 		print_relatives();
 		fprintf(stderr, "WARNING: Format may irrevocably delete this device's data.\n"
 			"You have 10 seconds to press Ctrl-C to cancel this operation.\n\n"