Skip to content

Commit ce266bf

Browse files
hreineckeigaw
authored andcommitted
libnvme: auto-generate 'subsysnqn' accessors
No reason why it needs to be treated specially. Signed-off-by: Hannes Reinecke <[email protected]>
1 parent f9446c2 commit ce266bf

6 files changed

Lines changed: 15 additions & 14 deletions

File tree

libnvme/src/accessors.ld

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ LIBNVME_ACCESSORS_3 {
4545
nvme_ctrl_get_serial;
4646
nvme_ctrl_get_sqsize;
4747
nvme_ctrl_get_transport;
48+
nvme_ctrl_get_subsysnqn;
4849
nvme_ctrl_get_traddr;
4950
nvme_ctrl_get_trsvcid;
5051
nvme_ctrl_get_dhchap_host_key;

libnvme/src/nvme/accessors.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,11 @@ const char *nvme_ctrl_get_transport(const struct nvme_ctrl *p)
216216
return p->transport;
217217
}
218218

219+
const char *nvme_ctrl_get_subsysnqn(const struct nvme_ctrl *p)
220+
{
221+
return p->subsysnqn;
222+
}
223+
219224
const char *nvme_ctrl_get_traddr(const struct nvme_ctrl *p)
220225
{
221226
return p->traddr;

libnvme/src/nvme/accessors.h

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -313,6 +313,14 @@ const char *nvme_ctrl_get_sqsize(const struct nvme_ctrl *p);
313313
*/
314314
const char *nvme_ctrl_get_transport(const struct nvme_ctrl *p);
315315

316+
/**
317+
* nvme_ctrl_get_subsysnqn() - Get subsysnqn.
318+
* @p: The &struct nvme_ctrl instance to query.
319+
*
320+
* Return: The value of the subsysnqn field, or NULL if not set.
321+
*/
322+
const char *nvme_ctrl_get_subsysnqn(const struct nvme_ctrl *p);
323+
316324
/**
317325
* nvme_ctrl_get_traddr() - Get traddr.
318326
* @p: The &struct nvme_ctrl instance to query.

libnvme/src/nvme/private.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ struct nvme_ctrl { /*!generate-accessors*/
195195
char *serial; //!accessors:readonly
196196
char *sqsize; //!accessors:readonly
197197
char *transport; //!accessors:readonly
198-
char *subsysnqn; //!accessors:none
198+
char *subsysnqn; //!accessors:readonly
199199
char *traddr; //!accessors:readonly
200200
char *trsvcid; //!accessors:readonly
201201
char *dhchap_host_key;

libnvme/src/nvme/tree.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -890,11 +890,6 @@ nvme_subsystem_t nvme_ctrl_get_subsystem(nvme_ctrl_t c)
890890
}
891891

892892

893-
const char *nvme_ctrl_get_subsysnqn(nvme_ctrl_t c)
894-
{
895-
return c->s ? c->s->subsysnqn : c->subsysnqn;
896-
}
897-
898893
char *nvme_ctrl_get_src_addr(nvme_ctrl_t c, char *src_addr, size_t src_addr_len)
899894
{
900895
size_t l;

libnvme/src/nvme/tree.h

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -734,14 +734,6 @@ char *nvme_ctrl_get_src_addr(nvme_ctrl_t c, char *src_addr, size_t src_addr_len)
734734
*/
735735
const char *nvme_ctrl_get_state(nvme_ctrl_t c);
736736

737-
/**
738-
* nvme_ctrl_get_subsysnqn() - Subsystem NQN of a controller
739-
* @c: Controller instance
740-
*
741-
* Return: Subsystem NQN of @c
742-
*/
743-
const char *nvme_ctrl_get_subsysnqn(nvme_ctrl_t c);
744-
745737
/**
746738
* nvme_ctrl_get_subsystem() - Parent subsystem of a controller
747739
* @c: Controller instance

0 commit comments

Comments
 (0)