cmds: free id_ctrl after use in nvme_get_telemetry_max

igaw · igaw · commit c79a59d5ea3c · 2026-03-04T16:01:53.000+01:00
id_ctrl is allocated with __nvme_alloc() but never freed.

Signed-off-by: Daniel Wagner &lt;wagi@kernel.org&gt;
diff --git a/libnvme/src/nvme/cmds.c b/libnvme/src/nvme/cmds.c
@@ -124,7 +124,7 @@ int nvme_get_uuid_list(struct nvme_transport_handle *hdl,
 int nvme_get_telemetry_max(struct nvme_transport_handle *hdl,
 		enum nvme_telemetry_da *da, size_t *data_tx)
 {
-	struct nvme_id_ctrl *id_ctrl = NULL;
+	_cleanup_free_ struct nvme_id_ctrl *id_ctrl = NULL;
 	struct nvme_passthru_cmd cmd;
 	int err;
 

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ int nvme_get_uuid_list(struct nvme_transport_handle *hdl,`
`124`	`124`	`int nvme_get_telemetry_max(struct nvme_transport_handle *hdl,`
`125`	`125`	`enum nvme_telemetry_da da, size_t data_tx)`
`126`	`126`	`{`
`127`		`- struct nvme_id_ctrl *id_ctrl = NULL;`
	`127`	`+ _cleanup_free_ struct nvme_id_ctrl *id_ctrl = NULL;`
`128`	`128`	`struct nvme_passthru_cmd cmd;`
`129`	`129`	`int err;`
`130`	`130`