docs: add deprecation not to --hostid

The --hostid option is deprecated and ignored. Update the
documentation accordingly.

Signed-off-by: Daniel Wagner <[email protected]>

Author: igaw

Documentation/nvme-config.txt

@@ -115,8 +115,8 @@ OPTIONS
 
 -I <hostid>::
 --hostid=<hostid>::
-	UUID(Universally Unique Identifier) to be discovered which should be
-	formatted.
+	Deprecated and ignored. This option is kept around for backwards
+	compatibility. Use --hostnqn instead.
 
 -S <secret>::
 --dhchap-secret=<secret>::

Documentation/nvme-connect-all.txt

@@ -105,8 +105,8 @@ OPTIONS
 
 -I <hostid>::
 --hostid=<hostid>::
-	UUID(Universally Unique Identifier) to be discovered which should be
-	formatted.
+	Deprecated and ignored. This option is kept around for backwards
+	compatibility. Use --hostnqn instead.
 
 -r <filename>::
 --raw=<filename>::

Documentation/nvme-connect.txt

@@ -93,8 +93,8 @@ OPTIONS
 
 -I <hostid>::
 --hostid=<hostid>::
-	UUID(Universally Unique Identifier) to be discovered which should be
-	formatted.
+	Deprecated and ignored. This option is kept around for backwards
+	compatibility. Use --hostnqn instead.
 
 -J <filename>::
 --config=<filename>::

Documentation/nvme-discover.txt

@@ -124,8 +124,8 @@ OPTIONS
 
 -I <hostid>::
 --hostid=<hostid>::
-	UUID(Universally Unique Identifier) to be discovered which should be
-	formatted.
+	Deprecated and ignored. This option is kept around for backwards
+	compatibility. Use --hostnqn instead.
 
 -r <filename>::
 --raw=<filename>::

libnvme/src/nvme/fabrics.c

@@ -705,9 +705,10 @@ static int build_options(nvme_host_t h, nvme_ctrl_t c, char **argstr)
 {
 	struct nvme_fabrics_config *cfg = nvme_ctrl_get_config(c);
 	const char *transport = nvme_ctrl_get_transport(c);
-	const char *hostnqn, *hostid, *hostkey, *ctrlkey = NULL;
+	const char *hostnqn, *hostkey, *ctrlkey = NULL;
 	bool discover = false, discovery_nqn = false;
 	struct nvme_global_ctx *ctx = h->ctx;
+	_cleanup_free_ char *hostid = NULL;
 	long keyring_id = 0;
 	long key_id = 0;
 	int ret;