fix: upload versioned binary to SFTP server on release tag push

The upload-test-binary job was never uploading a versioned binary
(e.g. nvme-cli-v3.0-a.3-x86_64) because:

1. upload.yml listened for `release: published` events, but releases
   are created by release.yml using GITHUB_TOKEN. GitHub prevents
   GITHUB_TOKEN-triggered actions from firing other workflow events,
   so `release: published` never fired.

2. The build step checked `GITHUB_EVENT_NAME == release` which also
   never evaluated to true for the same reason.

3. The container job defaults to `sh`, not `bash`, so `[[ ]]` syntax
   would have failed.

Fix: add `tags: v*` to the push trigger so the workflow runs when a
version tag is pushed, and use a POSIX-compatible `case` statement
checking `GITHUB_REF` to create the versioned binary using
`GITHUB_REF_NAME` as the tag name.

Co-authored-by: igaw <[email protected]>

Author: Copilot

.github/workflows/upload.yml

@@ -11,6 +11,8 @@ name: Upload
 on:
   push:
     branches: [master]
+    tags:
+      - 'v*'
   release:
     types: [published]
 
@@ -41,9 +43,11 @@ jobs:
           scripts/build.sh static
           mkdir upload
           cp .build-ci/nvme upload/nvme-cli-latest-x86_64
-          if [ "${GITHUB_EVENT_NAME}" = "release" ]; then
-            cp .build-ci/nvme "upload/nvme-cli-${VERSION}-x86_64"
-          fi
+          case "${GITHUB_REF}" in
+            refs/tags/v*)
+              cp .build-ci/nvme "upload/nvme-cli-${GITHUB_REF_NAME}-x86_64"
+              ;;
+          esac
 
       - uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0
         name: upload artifacts to github