Skip to content

Commit c4a1330

Browse files
committed
libnvme/cmds: change copy desc format 0h and 2h elbt to big-endian
Since the format 1h and 3h elbt values are set as big-endian. Also change the field name eilbrt to elbt as following spec. Signed-off-by: Tokunori Ikegami <[email protected]>
1 parent 14828a1 commit c4a1330

3 files changed

Lines changed: 12 additions & 12 deletions

File tree

libnvme/src/nvme/cmds.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -424,15 +424,15 @@ static inline void nvme_init_copy_range_elbt(__u8 *elbt, __u64 eilbrt)
424424
}
425425

426426
void nvme_init_copy_range(struct nvme_copy_range *copy, __u16 *nlbs,
427-
__u64 *slbas, __u32 *eilbrts, __u32 *elbatms,
427+
__u64 *slbas, __u32 *elbts, __u32 *elbatms,
428428
__u32 *elbats, __u16 nr)
429429
{
430430
int i;
431431

432432
for (i = 0; i < nr; i++) {
433433
copy[i].nlb = cpu_to_le16(nlbs[i]);
434434
copy[i].slba = cpu_to_le64(slbas[i]);
435-
copy[i].eilbrt = cpu_to_le32(eilbrts[i]);
435+
copy[i].elbt = cpu_to_be32(elbts[i]);
436436
copy[i].elbatm = cpu_to_le16(elbatms[i]);
437437
copy[i].elbat = cpu_to_le16(elbats[i]);
438438
}
@@ -455,7 +455,7 @@ void nvme_init_copy_range_f1(struct nvme_copy_range_f1 *copy, __u16 *nlbs,
455455

456456
void nvme_init_copy_range_f2(struct nvme_copy_range_f2 *copy, __u32 *snsids,
457457
__u16 *nlbs, __u64 *slbas, __u16 *sopts,
458-
__u32 *eilbrts, __u32 *elbatms, __u32 *elbats,
458+
__u32 *elbts, __u32 *elbatms, __u32 *elbats,
459459
__u16 nr)
460460
{
461461
int i;
@@ -465,7 +465,7 @@ void nvme_init_copy_range_f2(struct nvme_copy_range_f2 *copy, __u32 *snsids,
465465
copy[i].nlb = cpu_to_le16(nlbs[i]);
466466
copy[i].slba = cpu_to_le64(slbas[i]);
467467
copy[i].sopt = cpu_to_le16(sopts[i]);
468-
copy[i].eilbrt = cpu_to_le32(eilbrts[i]);
468+
copy[i].elbt = cpu_to_be32(elbts[i]);
469469
copy[i].elbatm = cpu_to_le16(elbatms[i]);
470470
copy[i].elbat = cpu_to_le16(elbats[i]);
471471
}

libnvme/src/nvme/cmds.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7150,13 +7150,13 @@ void nvme_init_dsm_range(struct nvme_dsm_range *dsm, __u32 *ctx_attrs,
71507150
* @copy: Copy range array
71517151
* @nlbs: Number of logical blocks
71527152
* @slbas: Starting LBA
7153-
* @eilbrts: Expected initial logical block reference tag
7153+
* @elbts: Expected initial logical block reference tag
71547154
* @elbatms: Expected logical block application tag mask
71557155
* @elbats: Expected logical block application tag
71567156
* @nr: Number of descriptors to construct
71577157
*/
71587158
void nvme_init_copy_range(struct nvme_copy_range *copy, __u16 *nlbs,
7159-
__u64 *slbas, __u32 *eilbrts, __u32 *elbatms,
7159+
__u64 *slbas, __u32 *elbts, __u32 *elbatms,
71607160
__u32 *elbats, __u16 nr);
71617161

71627162
/**
@@ -7197,14 +7197,14 @@ void nvme_init_copy_range_f2(struct nvme_copy_range_f2 *copy, __u32 *snsids,
71977197
* @nlbs: Number of logical blocks
71987198
* @slbas: Starting LBA
71997199
* @sopts: Source options
7200-
* @eilbrts: Expected initial logical block reference tag
7200+
* @elbts: Expected initial logical block reference tag
72017201
* @elbatms: Expected logical block application tag mask
72027202
* @elbats: Expected logical block application tag
72037203
* @nr: Number of descriptors to construct
72047204
*/
72057205
void nvme_init_copy_range_f3(struct nvme_copy_range_f3 *copy, __u32 *snsids,
72067206
__u16 *nlbs, __u64 *slbas, __u16 *sopts,
7207-
__u64 *eilbrts, __u32 *elbatms, __u32 *elbats,
7207+
__u64 *elbts, __u32 *elbatms, __u32 *elbats,
72087208
__u16 nr);
72097209

72107210
/**

libnvme/src/nvme/types.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6392,7 +6392,7 @@ struct nvme_dsm_range {
63926392
* @slba: Starting LBA
63936393
* @nlb: Number of Logical Blocks
63946394
* @rsvd18: Reserved
6395-
* @eilbrt: Expected Initial Logical Block Reference Tag /
6395+
* @elbt: Expected Initial Logical Block Reference Tag /
63966396
* Expected Logical Block Storage Tag
63976397
* @elbatm: Expected Logical Block Application Tag Mask
63986398
* @elbat: Expected Logical Block Application Tag
@@ -6402,7 +6402,7 @@ struct nvme_copy_range {
64026402
__le64 slba;
64036403
__le16 nlb;
64046404
__u8 rsvd18[6];
6405-
__le32 eilbrt;
6405+
__be32 elbt;
64066406
__le16 elbat;
64076407
__le16 elbatm;
64086408
};
@@ -6444,7 +6444,7 @@ enum nvme_copy_range_sopt {
64446444
* @nlb: Number of Logical Blocks
64456445
* @rsvd18: Reserved
64466446
* @sopt: Source Options
6447-
* @eilbrt: Expected Initial Logical Block Reference Tag /
6447+
* @elbt: Expected Initial Logical Block Reference Tag /
64486448
* Expected Logical Block Storage Tag
64496449
* @elbatm: Expected Logical Block Application Tag Mask
64506450
* @elbat: Expected Logical Block Application Tag
@@ -6456,7 +6456,7 @@ struct nvme_copy_range_f2 {
64566456
__le16 nlb;
64576457
__u8 rsvd18[4];
64586458
__le16 sopt;
6459-
__le32 eilbrt;
6459+
__be32 elbt;
64606460
__le16 elbat;
64616461
__le16 elbatm;
64626462
};

0 commit comments

Comments
 (0)