Skip to content

Commit aa9a6ff

Browse files
committed
libnvme: change copy_range name to copy_range_f0
Change both the struct name and the init API names. Note: For the API change libnvme.ld also changed. Signed-off-by: Tokunori Ikegami <[email protected]>
1 parent d8eaf65 commit aa9a6ff

6 files changed

Lines changed: 20 additions & 19 deletions

File tree

libnvme/src/libnvme.ld

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ LIBNVME_3 {
8282
nvme_hostnqn_generate_from_hostid;
8383
nvme_import_tls_key;
8484
nvme_import_tls_key_versioned;
85-
nvme_init_copy_range;
85+
nvme_init_copy_range_f0;
8686
nvme_init_copy_range_f1;
8787
nvme_init_copy_range_f2;
8888
nvme_init_copy_range_f3;

libnvme/src/nvme/cmds.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -423,9 +423,9 @@ static inline void nvme_init_copy_range_elbt(__u8 *elbt, __u64 eilbrt)
423423
elbt[0] = 0;
424424
}
425425

426-
void nvme_init_copy_range(struct nvme_copy_range *copy, __u16 *nlbs,
427-
__u64 *slbas, __u32 *elbts, __u32 *elbatms,
428-
__u32 *elbats, __u16 nr)
426+
void nvme_init_copy_range_f0(struct nvme_copy_range_f0 *copy, __u16 *nlbs,
427+
__u64 *slbas, __u32 *elbts, __u32 *elbatms,
428+
__u32 *elbats, __u16 nr)
429429
{
430430
int i;
431431

libnvme/src/nvme/cmds.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4425,7 +4425,7 @@ nvme_init_copy(struct nvme_passthru_cmd *cmd, __u32 nsid, __u64 sdlba,
44254425
data_len = nr * sizeof(struct nvme_copy_range_f3);
44264426
break;
44274427
default:
4428-
data_len = nr * sizeof(struct nvme_copy_range);
4428+
data_len = nr * sizeof(struct nvme_copy_range_f0);
44294429
break;
44304430
}
44314431

@@ -7146,7 +7146,7 @@ void nvme_init_dsm_range(struct nvme_dsm_range *dsm, __u32 *ctx_attrs,
71467146
__u32 *llbas, __u64 *slbas, __u16 nr_ranges);
71477147

71487148
/**
7149-
* nvme_init_copy_range() - Constructs a copy range structure
7149+
* nvme_init_copy_range_f0() - Constructs a copy range structure
71507150
* @copy: Copy range array
71517151
* @nlbs: Number of logical blocks
71527152
* @slbas: Starting LBA
@@ -7155,9 +7155,9 @@ void nvme_init_dsm_range(struct nvme_dsm_range *dsm, __u32 *ctx_attrs,
71557155
* @elbats: Expected logical block application tag
71567156
* @nr: Number of descriptors to construct
71577157
*/
7158-
void nvme_init_copy_range(struct nvme_copy_range *copy, __u16 *nlbs,
7159-
__u64 *slbas, __u32 *elbts, __u32 *elbatms,
7160-
__u32 *elbats, __u16 nr);
7158+
void nvme_init_copy_range_f0(struct nvme_copy_range_f0 *copy, __u16 *nlbs,
7159+
__u64 *slbas, __u32 *elbts, __u32 *elbatms,
7160+
__u32 *elbats, __u16 nr);
71617161

71627162
/**
71637163
* nvme_init_copy_range_f1() - Constructs a copy range f1 structure

libnvme/src/nvme/types.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6436,7 +6436,7 @@ struct nvme_dsm_range {
64366436
};
64376437

64386438
/**
6439-
* struct nvme_copy_range - Copy - Source Range Entries Descriptor Format
6439+
* struct nvme_copy_range_f0 - Copy - Source Range Entries Descriptor Format
64406440
* @rsvd0: Reserved
64416441
* @slba: Starting LBA
64426442
* @nlb: Number of Logical Blocks
@@ -6446,7 +6446,7 @@ struct nvme_dsm_range {
64466446
* @elbatm: Expected Logical Block Application Tag Mask
64476447
* @elbat: Expected Logical Block Application Tag
64486448
*/
6449-
struct nvme_copy_range {
6449+
struct nvme_copy_range_f0 {
64506450
__u8 rsvd0[8];
64516451
__le64 slba;
64526452
__le16 nlb;

libnvme/test/ioctl/misc.c

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -982,7 +982,7 @@ static void test_dsm(void)
982982
static void test_copy(void)
983983
{
984984
__u16 nr = TEST_COPY_NR, cev = 0, dspec = 0;
985-
int copy_size = sizeof(struct nvme_copy_range) * nr, err;
985+
int copy_size = sizeof(struct nvme_copy_range_f0) * nr, err;
986986
bool prinfor = false, prinfow = false, stcw = false,
987987
stcr = false, fua = false, lr = false;
988988
__u8 cetype = 0, dtype = 0, desfmt = 0xf;
@@ -992,7 +992,7 @@ static void test_copy(void)
992992
__u32 short_pi[TEST_COPY_NR] = { 0x1000, 0x20000000, 0x40000000 };
993993
__u32 elbatms[TEST_COPY_NR] = { 0x1ff, 0x3ff, 0x3ff };
994994
__u32 elbats[TEST_COPY_NR] = { 0x111, 0x222, 0x333 };
995-
__u8 expected_data[sizeof(struct nvme_copy_range) * TEST_COPY_NR] = {
995+
__u8 expected_data[sizeof(struct nvme_copy_range_f0) * TEST_COPY_NR] = {
996996
0, 0, 0, 0, 0, 0, 0, 0, 0, 0x10, 0, 0, 0, 0, 0, 0,
997997
0xa, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0x10, 0, 0x11, 1, 0xff, 1,
998998
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0x20, 0, 0, 0, 0,
@@ -1001,7 +1001,7 @@ static void test_copy(void)
10011001
0xc, 0, 0, 0, 0, 0, 0, 0, 0x40, 0, 0, 0, 0x33, 3, 0xff, 3
10021002
};
10031003

1004-
_cleanup_free_ struct nvme_copy_range *copy = NULL;
1004+
_cleanup_free_ struct nvme_copy_range_f0 *copy = NULL;
10051005

10061006
copy = calloc(1, copy_size);
10071007
check(copy, "copy: ENOMEM");
@@ -1016,13 +1016,14 @@ static void test_copy(void)
10161016
((dtype & 0xf) << 20) |
10171017
((prinfow & 0xf) << 26) |
10181018
((fua & 0x1) << 30) | ((lr & 0x1) << 31),
1019-
.data_len = nr * sizeof(struct nvme_copy_range),
1019+
.data_len = nr * sizeof(struct nvme_copy_range_f0),
10201020
.in_data = expected_data,
10211021
};
10221022
struct nvme_passthru_cmd cmd;
10231023

10241024
set_mock_io_cmds(&mock_io_cmd, 1);
1025-
nvme_init_copy_range(copy, nlbs, slbas, short_pi, elbatms, elbats, nr);
1025+
nvme_init_copy_range_f0(copy, nlbs, slbas, short_pi, elbatms, elbats,
1026+
nr);
10261027
nvme_init_copy(&cmd, TEST_NSID, sdlba, nr, desfmt,
10271028
prinfor, prinfow, cetype, dtype, stcw, stcr,
10281029
fua, lr, cev, dspec, (void *)copy);

nvme.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7768,7 +7768,7 @@ static int copy_cmd(int argc, char **argv, struct command *acmd, struct plugin *
77687768
__u32 elbats[256] = { 0 };
77697769

77707770
_cleanup_free_ union {
7771-
struct nvme_copy_range f0[256];
7771+
struct nvme_copy_range_f0 f0[256];
77727772
struct nvme_copy_range_f1 f1[256];
77737773
struct nvme_copy_range_f2 f2[256];
77747774
struct nvme_copy_range_f3 f3[256];
@@ -7920,8 +7920,8 @@ static int copy_cmd(int argc, char **argv, struct command *acmd, struct plugin *
79207920
eilbrts.long_pi, elbatms, elbats, nr);
79217921
break;
79227922
default:
7923-
nvme_init_copy_range(copy->f0, nlbs, slbas, eilbrts.short_pi,
7924-
elbatms, elbats, nr);
7923+
nvme_init_copy_range_f0(copy->f0, nlbs, slbas, eilbrts.short_pi,
7924+
elbatms, elbats, nr);
79257925
break;
79267926
}
79277927

0 commit comments

Comments
 (0)