Skip to content

Commit 8fc0355

Browse files
committed
libnvme/cmds: change copy desc format 0h and 2h elbt to big-endian
Since the format 1h and 3h elbt values are set as big-endian. Also change the field name eilbrt to elbt as following spec. Signed-off-by: Tokunori Ikegami <[email protected]>
1 parent 74d11e2 commit 8fc0355

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

libnvme/src/nvme/cmds.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5256,22 +5256,22 @@ nvme_init_copy_range_elbt(__u8 *elbt, __u64 eilbrt)
52565256
* @copy: Copy range array
52575257
* @nlbs: Number of logical blocks
52585258
* @slbas: Starting LBA
5259-
* @eilbrts: Expected initial logical block reference tag
5259+
* @elbts: Expected initial logical block reference tag
52605260
* @elbatms: Expected logical block application tag mask
52615261
* @elbats: Expected logical block application tag
52625262
* @nr: Number of descriptors to construct
52635263
*/
52645264
static inline void
52655265
nvme_init_copy_range(struct nvme_copy_range *copy, __u16 *nlbs,
5266-
__u64 *slbas, __u32 *eilbrts, __u32 *elbatms,
5266+
__u64 *slbas, __u32 *elbts, __u32 *elbatms,
52675267
__u32 *elbats, __u16 nr)
52685268
{
52695269
int i;
52705270

52715271
for (i = 0; i < nr; i++) {
52725272
copy[i].nlb = htole16(nlbs[i]);
52735273
copy[i].slba = htole64(slbas[i]);
5274-
copy[i].eilbrt = htole32(eilbrts[i]);
5274+
copy[i].elbt = htobe32(elbts[i]);
52755275
copy[i].elbatm = htole16(elbatms[i]);
52765276
copy[i].elbat = htole16(elbats[i]);
52775277
}
@@ -5310,15 +5310,15 @@ nvme_init_copy_range_f1(struct nvme_copy_range_f1 *copy, __u16 *nlbs,
53105310
* @nlbs: Number of logical blocks
53115311
* @slbas: Starting LBA
53125312
* @sopts: Source options
5313-
* @eilbrts: Expected initial logical block reference tag
5313+
* @elbts: Expected initial logical block reference tag
53145314
* @elbatms: Expected logical block application tag mask
53155315
* @elbats: Expected logical block application tag
53165316
* @nr: Number of descriptors to construct
53175317
*/
53185318
static inline void
53195319
nvme_init_copy_range_f2(struct nvme_copy_range_f2 *copy,
53205320
__u32 *snsids, __u16 *nlbs, __u64 *slbas, __u16 *sopts,
5321-
__u32 *eilbrts, __u32 *elbatms, __u32 *elbats,
5321+
__u32 *elbts, __u32 *elbatms, __u32 *elbats,
53225322
__u16 nr)
53235323
{
53245324
int i;
@@ -5328,7 +5328,7 @@ nvme_init_copy_range_f2(struct nvme_copy_range_f2 *copy,
53285328
copy[i].nlb = htole16(nlbs[i]);
53295329
copy[i].slba = htole64(slbas[i]);
53305330
copy[i].sopt = htole16(sopts[i]);
5331-
copy[i].eilbrt = htole32(eilbrts[i]);
5331+
copy[i].elbt = htobe32(elbts[i]);
53325332
copy[i].elbatm = htole16(elbatms[i]);
53335333
copy[i].elbat = htole16(elbats[i]);
53345334
}

libnvme/src/nvme/types.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6441,7 +6441,7 @@ struct nvme_dsm_range {
64416441
* @slba: Starting LBA
64426442
* @nlb: Number of Logical Blocks
64436443
* @rsvd18: Reserved
6444-
* @eilbrt: Expected Initial Logical Block Reference Tag /
6444+
* @elbt: Expected Initial Logical Block Reference Tag /
64456445
* Expected Logical Block Storage Tag
64466446
* @elbatm: Expected Logical Block Application Tag Mask
64476447
* @elbat: Expected Logical Block Application Tag
@@ -6451,7 +6451,7 @@ struct nvme_copy_range {
64516451
__le64 slba;
64526452
__le16 nlb;
64536453
__u8 rsvd18[6];
6454-
__le32 eilbrt;
6454+
__be32 elbt;
64556455
__le16 elbat;
64566456
__le16 elbatm;
64576457
};
@@ -6493,7 +6493,7 @@ enum nvme_copy_range_sopt {
64936493
* @nlb: Number of Logical Blocks
64946494
* @rsvd18: Reserved
64956495
* @sopt: Source Options
6496-
* @eilbrt: Expected Initial Logical Block Reference Tag /
6496+
* @elbt: Expected Initial Logical Block Reference Tag /
64976497
* Expected Logical Block Storage Tag
64986498
* @elbatm: Expected Logical Block Application Tag Mask
64996499
* @elbat: Expected Logical Block Application Tag
@@ -6505,7 +6505,7 @@ struct nvme_copy_range_f2 {
65056505
__le16 nlb;
65066506
__u8 rsvd18[4];
65076507
__le16 sopt;
6508-
__le32 eilbrt;
6508+
__be32 elbt;
65096509
__le16 elbat;
65106510
__le16 elbatm;
65116511
};

0 commit comments

Comments
 (0)