Skip to content

Commit 721b014

Browse files
martin-gpyigaw
authored andcommitted
fabrics: update get_entity_name() return handling
Copilot identified an issue with the return handling of get_entity_name() which could potentially display a misleading error message by nvme_strerror(). Fix the same. Signed-off-by: Martin George <[email protected]>
1 parent e71d925 commit 721b014

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

libnvme/src/nvme/fabrics.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1793,9 +1793,12 @@ static int nvmf_dim(nvme_ctrl_t c, enum nvmf_dim_tas tas, __u8 trtype,
17931793
MIN(sizeof(dim->eid), strlen(c->s->h->hostnqn)));
17941794

17951795
ret = get_entity_name(dim->ename, sizeof(dim->ename));
1796-
if (ret <= 0)
1796+
if (ret < 0)
17971797
nvme_msg(ctx, LOG_INFO, "%s: Failed to retrieve ENAME. %s.\n",
1798-
c->name, nvme_strerror(ret));
1798+
c->name, nvme_strerror(-ret));
1799+
else if (ret == 0)
1800+
nvme_msg(ctx, LOG_INFO, "%s: Failed to retrieve ENAME.\n",
1801+
c->name);
17991802

18001803
ret = get_entity_version(dim->ever, sizeof(dim->ever));
18011804
if (ret <= 0)

0 commit comments

Comments
 (0)