lib: define LIBNVME_LOG_* levels to replace syslog.h LOG_* constants

The library uses these only for log levels, so the remaining syslog
constants are unnecessary. Furthermore, removing the dependency on
syslog simplifies porting the project to other operating systems.

Signed-off-by: Daniel Wagner <[email protected]>

Author: igaw

fabrics.c

@@ -30,7 +30,6 @@
 #include <stdint.h>
 #include <stdio.h>
 #include <stdlib.h>
-#include <syslog.h>
 #include <time.h>
 #include <unistd.h>
 

libnvme/libnvme/nvme.i

@@ -508,14 +508,10 @@ struct libnvme_ns {
 	}
 	void log_level(const char *level) {
 		int log_level = DEFAULT_LOGLEVEL;
-		if (!strcmp(level, "debug")) log_level = LOG_DEBUG;
-		else if (!strcmp(level, "info")) log_level = LOG_INFO;
-		else if (!strcmp(level, "notice")) log_level = LOG_NOTICE;
-		else if (!strcmp(level, "warning")) log_level = LOG_WARNING;
-		else if (!strcmp(level, "err")) log_level = LOG_ERR;
-		else if (!strcmp(level, "crit")) log_level = LOG_CRIT;
-		else if (!strcmp(level, "alert")) log_level = LOG_ALERT;
-		else if (!strcmp(level, "emerg")) log_level = LOG_EMERG;
+		if (!strcmp(level, "debug")) log_level = LIBNVME_LOG_DEBUG;
+		else if (!strcmp(level, "info")) log_level = LIBNVME_LOG_INFO;
+		else if (!strcmp(level, "warning")) log_level = LIBNVME_LOG_WARN;
+		else if (!strcmp(level, "err")) log_level = LIBNVME_LOG_ERR;
 		libnvme_set_logging_level($self, log_level, false, false);
 	}
 	%pythoncode %{

libnvme/libnvme/tests/test-objects.py

@@ -45,7 +45,7 @@ def test_refresh_topology_does_not_raise(self):
 
     def test_log_level_all_valid_levels(self):
         ctx = nvme.global_ctx()
-        for level in ('debug', 'info', 'notice', 'warning', 'err', 'crit', 'alert', 'emerg'):
+        for level in ('debug', 'info', 'warning', 'err'):
             with self.subTest(level=level):
                 ctx.log_level(level)
 

libnvme/src/nvme/cmds.c

@@ -296,7 +296,7 @@ __public int libnvme_get_uuid_list(struct libnvme_transport_handle *hdl,
 	nvme_init_identify_ctrl(&cmd, &ctrl);
 	err = libnvme_submit_admin_passthru(hdl, &cmd);
 	if (err) {
-		libnvme_msg(hdl->ctx, LOG_ERR,
+		libnvme_msg(hdl->ctx, LIBNVME_LOG_ERR,
 			 "ERROR: nvme_identify_ctrl() failed 0x%x\n", err);
 		return err;
 	}