Skip to content

Commit 6460a6f

Browse files
committed
libnvme/fabrics: drop fabric_args from __create_discovery_ctrl()
All information is stored in nvmf_context, so use that instead. Signed-off-by: Hannes Reinecke <[email protected]>
1 parent 06ea1fb commit 6460a6f

1 file changed

Lines changed: 8 additions & 9 deletions

File tree

libnvme/src/nvme/fabrics.c

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2070,21 +2070,20 @@ static int nvme_add_ctrl(struct nvmf_context *fctx,
20702070

20712071
static int __create_discovery_ctrl(struct nvme_global_ctx *ctx,
20722072
struct nvmf_context *fctx, nvme_host_t h,
2073-
struct nvme_fabrics_config *cfg, struct fabric_args *trcfg,
2074-
struct nvme_ctrl **ctrl)
2073+
struct nvme_fabrics_config *cfg, struct nvme_ctrl **ctrl)
20752074
{
20762075
nvme_ctrl_t c;
20772076
int tmo, ret;
20782077

2079-
ret = nvme_create_ctrl(ctx, trcfg->subsysnqn, trcfg->transport,
2080-
trcfg->traddr, trcfg->host_traddr,
2081-
trcfg->host_iface, trcfg->trsvcid, &c);
2078+
ret = nvme_create_ctrl(ctx, fctx->subsysnqn, fctx->transport,
2079+
fctx->traddr, fctx->host_traddr,
2080+
fctx->host_iface, fctx->trsvcid, &c);
20822081
if (ret)
20832082
return ret;
20842083

20852084
nvme_ctrl_set_discovery_ctrl(c, true);
20862085
nvme_ctrl_set_unique_discovery_ctrl(c,
2087-
strcmp(trcfg->subsysnqn, NVME_DISC_SUBSYS_NAME));
2086+
strcmp(fctx->subsysnqn, NVME_DISC_SUBSYS_NAME));
20882087
tmo = set_discovery_kato(fctx, cfg);
20892088

20902089
if (nvme_ctrl_get_unique_discovery_ctrl(c) && fctx->hostkey) {
@@ -2114,7 +2113,7 @@ static int nvmf_create_discovery_ctrl(struct nvme_global_ctx *ctx,
21142113
struct nvme_ctrl *c;
21152114
int ret;
21162115

2117-
ret = __create_discovery_ctrl(ctx, fctx, h, cfg, trcfg, &c);
2116+
ret = __create_discovery_ctrl(ctx, fctx, h, cfg, &c);
21182117
if (ret)
21192118
return ret;
21202119

@@ -2158,8 +2157,8 @@ static int nvmf_create_discovery_ctrl(struct nvme_global_ctx *ctx,
21582157
nvme_disconnect_ctrl(c);
21592158
nvme_free_ctrl(c);
21602159

2161-
trcfg->subsysnqn = id->subnqn;
2162-
ret = __create_discovery_ctrl(ctx, fctx, h, cfg, trcfg, &c);
2160+
fctx->subsysnqn = id->subnqn;
2161+
ret = __create_discovery_ctrl(ctx, fctx, h, cfg, &c);
21632162
if (ret)
21642163
return ret;
21652164

0 commit comments

Comments
 (0)