Skip to content

Commit 63e7fcf

Browse files
ikegami-tigaw
authored andcommitted
nvme: check fw-commit command ca value with definition
Use the definition values instead of the hard coded values. Signed-off-by: Tokunori Ikegami <[email protected]>
1 parent bac0214 commit 63e7fcf

1 file changed

Lines changed: 10 additions & 1 deletion

File tree

nvme.c

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5326,10 +5326,19 @@ static int fw_commit(int argc, char **argv, struct command *acmd, struct plugin
53265326
nvme_show_error("invalid slot:%d", cfg.slot);
53275327
return -EINVAL;
53285328
}
5329-
if (cfg.action > 7 || cfg.action == 4 || cfg.action == 5) {
5329+
5330+
switch (cfg.action) {
5331+
case NVME_FW_COMMIT_CA_REPLACE:
5332+
case NVME_FW_COMMIT_CA_REPLACE_AND_ACTIVATE:
5333+
case NVME_FW_COMMIT_CA_SET_ACTIVE:
5334+
case NVME_FW_COMMIT_CA_REPLACE_BOOT_PARTITION:
5335+
case NVME_FW_COMMIT_CA_ACTIVATE_BOOT_PARTITION:
5336+
break;
5337+
default:
53305338
nvme_show_error("invalid action:%d", cfg.action);
53315339
return -EINVAL;
53325340
}
5341+
53335342
if (cfg.bpid > 1) {
53345343
nvme_show_error("invalid boot partition id:%d", cfg.bpid);
53355344
return -EINVAL;

0 commit comments

Comments
 (0)