fabrics: do no try do disconnect invalid ctrl

igaw · igaw · commit 61963916c2a4 · 2026-02-23T09:45:26.000+01:00
The ctrl object (child) can be NULL when either discovery is false or
_nvmf_discovery fails. Thus only disconnect when it is a valid pointer.

Signed-off-by: Daniel Wagner &lt;wagi@kernel.org&gt;
diff --git a/libnvme/src/nvme/fabrics.c b/libnvme/src/nvme/fabrics.c
@@ -2253,7 +2253,7 @@ static int _nvmf_discovery(struct nvme_global_ctx *ctx,
 			if (discover)
 				_nvmf_discovery(ctx, fctx, true, child);
 
-			if (disconnect) {
+			if (child && disconnect) {
 				nvme_disconnect_ctrl(child);
 				nvme_free_ctrl(child);
 			}

Original file line number	Diff line number	Diff line change
`@@ -2253,7 +2253,7 @@ static int _nvmf_discovery(struct nvme_global_ctx *ctx,`
`2253`	`2253`	`if (discover)`
`2254`	`2254`	`_nvmf_discovery(ctx, fctx, true, child);`
`2255`	`2255`
`2256`		`- if (disconnect) {`
	`2256`	`+ if (child && disconnect) {`
`2257`	`2257`	`nvme_disconnect_ctrl(child);`
`2258`	`2258`	`nvme_free_ctrl(child);`
`2259`	`2259`	`}`