Skip to content

Commit 5f6138c

Browse files
plugin/wdc: Fix UUID search for SN640 and SN655
The current code is checking both the pci device id and UUID. The pci device id check is not required and causes this check to fail in nvme over fabrics cases so it was removed. Signed-off-by: jeff-lien-sndk <[email protected]> Reviewed-by: brandon-paupore-sndk <[email protected]>
1 parent 7dc37f7 commit 5f6138c

2 files changed

Lines changed: 3 additions & 5 deletions

File tree

plugins/wdc/wdc-nvme.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2757,8 +2757,7 @@ static bool get_dev_mgment_data(struct nvme_global_ctx *ctx, struct nvme_transpo
27572757
* check for the WDC UUID second.
27582758
*/
27592759
uuid_index = nvme_uuid_find(&uuid_list, WDC_UUID);
2760-
if (uuid_index < 0 &&
2761-
(wdc_is_sn640_3(device_id) || wdc_is_sn655(device_id)))
2760+
if (uuid_index < 0)
27622761
uuid_index = nvme_uuid_find(&uuid_list, WDC_UUID_SN640_3);
27632762
}
27642763

@@ -2827,8 +2826,7 @@ static bool get_dev_mgment_cbs_data(struct nvme_global_ctx *ctx, struct nvme_tra
28272826
* check for the WDC UUID second.
28282827
*/
28292828
uuid_index = nvme_uuid_find(&uuid_list, WDC_UUID);
2830-
if (uuid_index < 0 &&
2831-
(wdc_is_sn640_3(device_id) || wdc_is_sn655(device_id)))
2829+
if (uuid_index < 0)
28322830
uuid_index = nvme_uuid_find(&uuid_list, WDC_UUID_SN640_3);
28332831
}
28342832

plugins/wdc/wdc-nvme.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
#if !defined(WDC_NVME) || defined(CMD_HEADER_MULTI_READ)
66
#define WDC_NVME
77

8-
#define WDC_PLUGIN_VERSION "2.14.6"
8+
#define WDC_PLUGIN_VERSION "2.14.7"
99
#include "cmd.h"
1010

1111
PLUGIN(NAME("wdc", "Western Digital vendor specific extensions", WDC_PLUGIN_VERSION),

0 commit comments

Comments
 (0)