Skip to content

Commit 56f4b49

Browse files
committed
lib: remove the unreleased linker section
The symbol versioning never really worked, thus it's adding unnecessary complexity. Thus the guarantee is that no existing symbols gets changed. Signed-off-by: Daniel Wagner <[email protected]>
1 parent fb51505 commit 56f4b49

2 files changed

Lines changed: 1 addition & 38 deletions

File tree

libnvme/src/libnvme.ld

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
# SPDX-License-Identifier: LGPL-2.1-or-later
2-
LIBNVME_UNRELEASED {
3-
};
42

5-
LIBNVME_2_0 {
3+
LIBNVME_3 {
64
global:
75
nvme_clear_etdas;
86
nvme_close;

scripts/release.sh

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -108,41 +108,6 @@ if [ "$build_doc" = true ]; then
108108
git commit -s -m "doc: Regenerate all docs for $VERSION"
109109
fi
110110

111-
declare -A ldscripts
112-
ldscripts=(
113-
[libnvme/src/libnvme.ld]=LIBNVME
114-
)
115-
116-
lib_ver="${ver//./_}"
117-
118-
for ld_file in "${!ldscripts[@]}"
119-
do
120-
lib_name=${ldscripts[$ld_file]}
121-
122-
if [ ! -f "${ld_file}" ]; then
123-
continue
124-
fi
125-
126-
lib_unreleased="${lib_name}_UNRELEASED"
127-
128-
# Check if UNRELEASED has symbols
129-
if ! awk -v lib_unreleased="$lib_unreleased" '
130-
$0 ~ "^"lib_unreleased { in_section = 1; next }
131-
in_section && $0 ~ /\}/ { exit }
132-
in_section && $0 !~ /^[[:space:]]*($|\/|\/\*|\*|#)/ { found = 1; exit }
133-
END { exit !found }
134-
' "${ld_file}"; then
135-
continue
136-
fi
137-
138-
sed -i \
139-
-e "s/^${lib_unreleased}\s*{/&\n};\n\n${lib_name}_${lib_ver} {/" \
140-
"$ld_file"
141-
142-
git add "${ld_file}"
143-
echo "${ld_file} updated."
144-
done
145-
146111
# update meson.build
147112
sed -i -e "0,/[ \t]version: /s/\([ \t]version: \).*/\1\'$ver\',/" meson.build
148113
git add meson.build

0 commit comments

Comments
 (0)