Refactored signal compatibility

Moved signal.h compatibility into nvme/signal.h

Author: bgoing-micron-oss

libnvme/src/nvme/signal.h

@@ -0,0 +1,49 @@
+/* SPDX-License-Identifier: LGPL-2.1-or-later */
+/*
+ * This file is part of libnvme.
+ * Copyright (c) 2026 Micron Technology, Inc.
+ *
+ * Cross-platform compatibility for signal.h.
+ * Provides functionality that may be missing on some platforms.
+ * Compatibility is not comprehensive. Only functionality required by
+ * nvme-cli and libnvme is included.
+ * 
+ * Authors: Brandon Busacker <[email protected]>
+ *          Broc Going <[email protected]>
+ */
+#pragma once
+
+#include <signal.h>
+
+#if defined(_WIN32) || defined(_WIN64)
+
+/* signal.h POSIX compatibility - Windows doesn't have sigaction */
+
+struct sigaction {
+	void (*sa_handler)(int);
+	int sa_flags;
+	int sa_mask;  /* simplified - normally sigset_t */
+};
+
+static inline int sigemptyset(int *set)
+{
+	*set = 0;
+	return 0;
+}
+
+/*
+ * Simplified signal handling using Windows signal() function
+ * This is sufficient for handling SIGINT with no mask or flags.
+ */
+static inline int sigaction(int signum, const struct sigaction *act,
+			struct sigaction *oldact)
+{
+	(void)oldact; /* ignore old action for simplicity */
+	if (act && act->sa_handler) {
+		signal(signum, act->sa_handler);
+		return 0;
+	}
+	return -1;
+}
+
+#endif

libnvme/src/platform/windows.h

@@ -43,33 +43,3 @@ static inline void libnvme_init(void)
 	_setmode(_fileno(stdout), O_BINARY);
 	_setmode(_fileno(stderr), O_BINARY);
 }
-
-
-/* signal.h POSIX compatibility - Windows doesn't have sigaction */
-
-struct sigaction {
-	void (*sa_handler)(int);
-	int sa_flags;
-	int sa_mask;  /* simplified - normally sigset_t */
-};
-
-static inline int sigemptyset(int *set)
-{
-	*set = 0;
-	return 0;
-}
-
-/*
- * Simplified signal handling using Windows signal() function
- * This is sufficient for handling SIGINT with no mask or flags.
- */
-static inline int sigaction(int signum, const struct sigaction *act,
-			struct sigaction *oldact)
-{
-	(void)oldact; /* ignore old action for simplicity */
-	if (act && act->sa_handler) {
-		signal(signum, act->sa_handler);
-		return 0;
-	}
-	return -1;
-}

plugins/amzn/amzn-nvme.c

@@ -7,6 +7,7 @@
 #include <unistd.h>
 #include <inttypes.h>
 
+#include <nvme/signal.h>
 #include <libnvme.h>
 
 #include "common.h"

util/sighdl.c

@@ -3,7 +3,7 @@
 #include <errno.h>
 #include <stddef.h>
 
-#include <platform/includes.h>
+#include <nvme/signal.h>
 
 #include "sighdl.h"