cmds: remove nvme_fw_download_seq

nvme-cli implements firmware download with additional checks, making it
more robust and safer to use. There are no users of this function, so
remove it.

Signed-off-by: Daniel Wagner <[email protected]>

Author: igaw

libnvme/src/libnvme.ld

@@ -42,7 +42,6 @@ LIBNVME_3 {
 		nvme_free_host;
 		nvme_free_ns;
 		nvme_free_subsystem;
-		nvme_fw_download_seq;
 		nvme_gen_dhchap_key;
 		nvme_generate_tls_key_identity;
 		nvme_generate_tls_key_identity_compat;

libnvme/src/nvme/cmds.c

@@ -15,34 +15,6 @@
 #include "cleanup.h"
 #include "private.h"
 
-int nvme_fw_download_seq(struct nvme_transport_handle *hdl, bool ish,
-		__u32 size, __u32 xfer, __u32 offset, void *buf)
-{
-	struct nvme_passthru_cmd cmd;
-	void *data = buf;
-	int err = 0;
-
-	if (ish && nvme_transport_handle_is_mi(hdl))
-		nvme_init_mi_cmd_flags(&cmd, ish);
-
-	while (size > 0) {
-		__u32 chunk = min(xfer, size);
-
-		err = nvme_init_fw_download(&cmd, data, chunk, offset);
-		if (err)
-			break;
-		err = nvme_submit_admin_passthru(hdl, &cmd);
-		if (err)
-			break;
-
-		data += chunk;
-		size -= chunk;
-		offset += chunk;
-	}
-
-	return err;
-}
-
 int nvme_set_etdas(struct nvme_transport_handle *hdl, bool *changed)
 {
 	struct nvme_feat_host_behavior da4;

libnvme/src/nvme/cmds.h

@@ -5227,21 +5227,6 @@ nvme_init_mi_cmd_flags(struct nvme_passthru_cmd *cmd, bool ish)
 			NVME_MI_ADMIN_CFLAGS_ISH_MASK);
 }
 
-/**
- * nvme_fw_download_seq() - Firmware download sequence
- * @hdl:	Transport handle
- * @ish:	Ignore Shutdown (for NVMe-MI command)
- * @size:	Total size of the firmware image to transfer
- * @xfer:	Maximum size to send with each partial transfer
- * @offset:	Starting offset to send with this firmware download
- * @buf:	Address of buffer containing all or part of the firmware image.
- *
- * Return: 0 on success, the nvme command status if a response was
- * received (see &enum nvme_status_field) or a negative error otherwise.
- */
-int nvme_fw_download_seq(struct nvme_transport_handle *hdl, bool ish,
-			__u32 size, __u32 xfer, __u32 offset, void *buf);
-
 /**
  * nvme_set_etdas() - Set the Extended Telemetry Data Area 4 Supported bit
  * @hdl:	Transport handle