nvme-wrap: handle get log rotational media info correctly

ikegami-t · igaw · commit 30655885306e · 2025-02-10T13:46:38.000+01:00
Return error for the missing get log rotational media function
for non MI devices.

Signed-off-by: Tokunori Ikegami &lt;ikegami.t@gmail.com&gt;
diff --git a/nvme-wrap.c b/nvme-wrap.c
@@ -440,5 +440,8 @@ int nvme_cli_get_log_mgmt_addr_list(struct nvme_dev *dev, __u32 len,
 int nvme_cli_get_log_rotational_media_info(struct nvme_dev *dev, __u16 endgid, __u32 len,
 					   struct nvme_rotational_media_info_log *info)
 {
-	return do_admin_op(get_log_rotational_media_info, dev, endgid, len, info);
+	if (dev->type == NVME_DEV_DIRECT)
+		return nvme_get_log_rotational_media_info(dev->direct.fd, endgid, len, info);
+
+	return -ENODEV;
 }

Original file line number	Diff line number	Diff line change
`@@ -440,5 +440,8 @@ int nvme_cli_get_log_mgmt_addr_list(struct nvme_dev *dev, __u32 len,`
`440`	`440`	`int nvme_cli_get_log_rotational_media_info(struct nvme_dev *dev, __u16 endgid, __u32 len,`
`441`	`441`	`struct nvme_rotational_media_info_log *info)`
`442`	`442`	`{`
`443`		`- return do_admin_op(get_log_rotational_media_info, dev, endgid, len, info);`
	`443`	`+ if (dev->type == NVME_DEV_DIRECT)`
	`444`	`+ return nvme_get_log_rotational_media_info(dev->direct.fd, endgid, len, info);`
	`445`	`+`
	`446`	`+ return -ENODEV;`
`444`	`447`	`}`