nvmf: fix generator emitting setters for read-only members in .ld files

generate_ld() always emitted both getter and setter entries regardless
of the member's is_const flag, unlike generate_hdr() and generate_src()
which both gate the setter on not is_const. As a result, accessors.ld
exported setter symbols that had no __public definition in accessors.c.

Also introduce LD_BANNER (a compact copyright block without the ASCII
art) for generated .ld files, since the "Generated Code" art is only
useful in .h/.c files that editors open regularly.

Regenerate accessors.ld to remove the spurious setter entries and
update the banner.

Signed-off-by: Martin Belanger <[email protected]>

Author: Martin Belanger

libnvme/src/accessors.ld

@@ -61,6 +61,7 @@ LIBNVME_ACCESSORS_3 {
 		libnvme_ctrl_get_cntrltype;
 		libnvme_ctrl_get_cntlid;
 		libnvme_ctrl_get_dctype;
+		libnvme_ctrl_get_phy_slot;
 		libnvme_ctrl_get_host_traddr;
 		libnvme_ctrl_get_host_iface;
 		libnvme_ctrl_get_discovery_ctrl;
@@ -71,7 +72,6 @@ LIBNVME_ACCESSORS_3 {
 		libnvme_ctrl_set_discovered;
 		libnvme_ctrl_get_persistent;
 		libnvme_ctrl_set_persistent;
-		libnvme_ctrl_get_phy_slot;
 		libnvme_subsystem_get_name;
 		libnvme_subsystem_get_sysfs_dir;
 		libnvme_subsystem_get_subsysnqn;

libnvme/tools/generator/generate-accessors.py

@@ -74,6 +74,16 @@
     " */"
 )
 
+LD_BANNER = (
+    "/**\n"
+    " * This file is part of libnvme.\n"
+    " *\n"
+    " * Copyright (c) 2025, Dell Technologies Inc. or its subsidiaries.\n"
+    " * Authors: Martin Belanger <[email protected]>\n"
+    " *\n"
+    " */"
+)
+
 # ---------------------------------------------------------------------------
 # Regular expressions
 # ---------------------------------------------------------------------------
@@ -500,10 +510,9 @@ def generate_src(f, prefix, struct_name, members):
 def generate_ld(f, prefix, struct_name, members):
     """Write linker version-script entries for all members of one struct."""
     for member in members:
-        f.write(
-            f'\t\t{_get_name(prefix, struct_name, member.name)};\n'
-            f'\t\t{_set_name(prefix, struct_name, member.name)};\n'
-        )
+        f.write(f'\t\t{_get_name(prefix, struct_name, member.name)};\n')
+        if not member.is_const:
+            f.write(f'\t\t{_set_name(prefix, struct_name, member.name)};\n')
 
 
 # ---------------------------------------------------------------------------
@@ -656,7 +665,7 @@ def main():
         f.write(
             f'{SPDX_LD}\n'
             f'\n'
-            f'{BANNER}\n'
+            f'{LD_BANNER}\n'
             f'\n'
             f'LIBNVME_ACCESSORS_3 {{\n'
             f'\tglobal:\n'