Skip to content

Commit 0632a18

Browse files
committed
nvme: check fw-commit command ca value with definition
Use the definition values instead of the hard coded values. Signed-off-by: Tokunori Ikegami <[email protected]>
1 parent 86be4e0 commit 0632a18

1 file changed

Lines changed: 10 additions & 1 deletion

File tree

nvme.c

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5323,10 +5323,19 @@ static int fw_commit(int argc, char **argv, struct command *acmd, struct plugin
53235323
nvme_show_error("invalid slot:%d", cfg.slot);
53245324
return -EINVAL;
53255325
}
5326-
if (cfg.action > 7 || cfg.action == 4 || cfg.action == 5) {
5326+
5327+
switch (cfg.action) {
5328+
case NVME_FW_COMMIT_CA_REPLACE:
5329+
case NVME_FW_COMMIT_CA_REPLACE_AND_ACTIVATE:
5330+
case NVME_FW_COMMIT_CA_SET_ACTIVE:
5331+
case NVME_FW_COMMIT_CA_REPLACE_BOOT_PARTITION:
5332+
case NVME_FW_COMMIT_CA_ACTIVATE_BOOT_PARTITION:
5333+
break;
5334+
default:
53275335
nvme_show_error("invalid action:%d", cfg.action);
53285336
return -EINVAL;
53295337
}
5338+
53305339
if (cfg.bpid > 1) {
53315340
nvme_show_error("invalid boot partition id:%d", cfg.bpid);
53325341
return -EINVAL;

0 commit comments

Comments
 (0)