tests: add mcl/mssrl/msrc limit checks to nvme_copy_test

The copy test can only run with valid mcl, mssrl, and msrc values.
Therefore, check that they are non-zero. QEMU’s default namespace
settings set these values to 0. The user must set them explicitly, e.g

	-device nvme-ns,drive=ns0,nsid=1,mcl=1024,mssrl=1024,msrc=63

Signed-off-by: Daniel Wagner <[email protected]>

Author: igaw

tests/nvme_copy_test.py

@@ -18,7 +18,7 @@
 
 import json
 
-from nvme_test import TestNVMe
+from nvme_test import TestNVMe, to_decimal
 
 
 class TestNVMeCopy(TestNVMe):
@@ -36,6 +36,9 @@ def setUp(self):
         super().setUp()
         self.ocfs = self.get_ocfs()
         self.original_cdfe = None
+        self.mcl = to_decimal(self.get_id_ns_field_value("mcl"))
+        self.mssrl = to_decimal(self.get_id_ns_field_value("mssrl"))
+        self.msrc = to_decimal(self.get_id_ns_field_value("msrc"))
         cross_namespace_copy = self.ocfs & 0xc
         if cross_namespace_copy:
             get_features_cmd = f"{self.nvme_bin} feat host-behavior-support " + \
@@ -85,6 +88,14 @@ def _check_format_supported(self, desc_format):
         if not self.ocfs & (1 << desc_format):
             self.skipTest(f"descriptor format {desc_format} is not supported")
 
+    def _check_ns_copy_limits(self):
+        """ Skip test if namespace copy limits (mcl, mssrl, msrc) are not set """
+        missing = [name for name, val in
+                   [("mcl", self.mcl), ("mssrl", self.mssrl), ("msrc", self.msrc)]
+                   if val == 0]
+        if missing:
+            self.skipTest(f"{', '.join(missing)} are 0, copy not supported on this namespace")
+
     def copy(self, sdlba, blocks, slbs, **kwargs):
         """ Wrapper for nvme copy
             - Args:
@@ -112,29 +123,35 @@ def copy(self, sdlba, blocks, slbs, **kwargs):
     def test_copy_format_0(self):
         """ Test copy with descriptor format 0 """
         self._check_format_supported(0)
+        self._check_ns_copy_limits()
         self.copy(0, 1, 2, descriptor_format=0)
 
     def test_copy_format_1(self):
         """ Test copy with descriptor format 1 """
         self._check_format_supported(1)
+        self._check_ns_copy_limits()
         self.copy(0, 1, 2, descriptor_format=1)
 
     def test_copy_format_2(self):
         """ Test copy with descriptor format 2 """
         self._check_format_supported(2)
+        self._check_ns_copy_limits()
         self.copy(0, 1, 2, descriptor_format=2, snsids=self.ns1_nsid)
 
     def test_copy_format_2_sopts(self):
         """ Test copy with descriptor format 2 and source options """
         self._check_format_supported(2)
+        self._check_ns_copy_limits()
         self.copy(0, 1, 2, descriptor_format=2, snsids=self.ns1_nsid, sopts=0)
 
     def test_copy_format_3(self):
         """ Test copy with descriptor format 3 """
         self._check_format_supported(3)
+        self._check_ns_copy_limits()
         self.copy(0, 1, 2, descriptor_format=3, snsids=self.ns1_nsid)
 
     def test_copy_format_3_sopts(self):
         """ Test copy with descriptor format 3 and source options """
         self._check_format_supported(3)
+        self._check_ns_copy_limits()
         self.copy(0, 1, 2, descriptor_format=3, snsids=self.ns1_nsid, sopts=0)

tests/nvme_test.py

@@ -350,6 +350,22 @@ def get_id_ctrl_field_value(self, field):
                         f"ERROR : reading field '{field}' failed")
         return str(json_output[field])
 
+    def get_id_ns_field_value(self, field):
+        """ Wrapper for extracting id-ns field values
+            - Args:
+                - field : field name to extract
+            - Returns:
+                - Field value of the given field as a string
+        """
+        id_ns_cmd = f"{self.nvme_bin} id-ns {self.ns1} " + \
+            "--output-format=json"
+        result = self.run_cmd(id_ns_cmd)
+        self.assertEqual(result.returncode, 0, "ERROR : reading id-ns failed")
+        json_output = json.loads(result.stdout)
+        self.assertTrue(field in json_output,
+                        f"ERROR : reading field '{field}' failed")
+        return str(json_output[field])
+
     def get_ocfs(self):
         """ Wrapper for extracting optional copy formats supported
             - Args: