Make fabrics optional #2138
igawcheckpatch.yml
on: pull_request
checkpatch review
19s
Annotations
10 errors
|
checkpatch review:
libnvme/src/nvme/linux.h#L402
ERROR: Bad function definition - char *nvme_hostnqn_generate() should probably be char *nvme_hostnqn_generate(void)
|
|
checkpatch review:
libnvme/src/nvme/linux.c#L1795
ERROR: Bad function definition - char *nvme_hostid_from_file() should probably be char *nvme_hostid_from_file(void)
|
|
checkpatch review:
libnvme/src/nvme/linux.c#L1782
ERROR: Bad function definition - char *nvme_hostnqn_from_file() should probably be char *nvme_hostnqn_from_file(void)
|
|
checkpatch review:
libnvme/src/nvme/linux.c#L1759
ERROR: Bad function definition - char *nvme_hostnqn_generate() should probably be char *nvme_hostnqn_generate(void)
|
|
checkpatch review:
libnvme/src/nvme/linux.c#L1726
ERROR: Bad function definition - char *nvme_hostid_generate() should probably be char *nvme_hostid_generate(void)
|
|
checkpatch review:
libnvme/src/nvme/linux.c#L1721
WARNING: Missing a blank line after declarations
|
|
checkpatch review:
libnvme/src/nvme/linux.c#L1697
WARNING: Block comments use a trailing */ on a separate line
|
|
checkpatch review:
libnvme/src/nvme/linux.c#L1684
WARNING: Missing a blank line after declarations
|
|
checkpatch review:
libnvme/src/nvme/linux.c#L1658
WARNING: quoted string split across lines
|
|
checkpatch review:
libnvme/src/nvme/linux.c#L1638
WARNING: Prefer kstrto<type> to single variable sscanf
|