fabrics: fix a check-after-dereference error in nvmf_discovery_log()

maurizio-lombardi · dwsuse · commit d516933bcfda · 2022-11-09T10:32:32.000+01:00
logp pointer can't be NULL, because it has already been dereferenced,
the function should check *logp instead.

Signed-off-by: Maurizio Lombardi &lt;mlombard@redhat.com&gt;
diff --git a/src/nvme/fabrics.c b/src/nvme/fabrics.c
@@ -894,7 +894,7 @@ int nvmf_get_discovery_log(nvme_ctrl_t c, struct nvmf_discovery_log **logp,
 		.ot = false,
 	};
 	*logp = nvme_discovery_log(c, &args, max_retries);
-	return logp ? 0 : -1;
+	return *logp ? 0 : -1;
 }
 
 struct nvmf_discovery_log *nvmf_get_discovery_wargs(struct nvme_get_discovery_args *args)

Original file line number	Diff line number	Diff line change
`@@ -894,7 +894,7 @@ int nvmf_get_discovery_log(nvme_ctrl_t c, struct nvmf_discovery_log **logp,`
`894`	`894`	`.ot = false,`
`895`	`895`	`};`
`896`	`896`	`*logp = nvme_discovery_log(c, &args, max_retries);`
`897`		`- return logp ? 0 : -1;`
	`897`	`+ return *logp ? 0 : -1;`
`898`	`898`	`}`
`899`	`899`
`900`	`900`	`struct nvmf_discovery_log nvmf_get_discovery_wargs(struct nvme_get_discovery_args args)`