Skip to content

Commit d0b0215

Browse files
committed
build: disable liburing support per default
The Get Log Page command can be used with io_uring. However, the way it is implemented is highly questionable. In other words, it's a bit crazy. Therefore, do not enable it unless you fully understand what you're doing. Signed-off-by: Daniel Wagner <[email protected]>
1 parent 3caa403 commit d0b0215

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ A few build options can be specified on the command line when invoking meson.
155155
| libdbus | auto, enabled, [disabled] | Enables D-Bus dependent features (libnvme-mi: End point discovery), adds build dependency on libdbus |
156156
| json-c | [auto], enabled, disabled | (recommended) Enables JSON-C dependend features (e.g. config.json parsing), adds build depdency on json-c |
157157
| keyutils | [auto], enabled, disabled | Enables keyutils dependent features (e.g. authentication), adds build dependency on keyutils |
158-
| liburing | [auto], enabled, disabled | Enables liburing dependent features (e.g. get log page by uring cmd), adds build depdency on liburing |
158+
| liburing | auto, enabled, [disabled] | Enables liburing dependent features (e.g. get log page by uring cmd), adds build depdency on liburing, very questionable feature. Don't enable it |
159159

160160
See the full configuration options with
161161

meson_options.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@ option('openssl', type : 'feature', value: 'auto', description : 'OpenSSL suppor
1414
option('libdbus', type : 'feature', value: 'disabled', description : 'libdbus support')
1515
option('json-c', type : 'feature', value: 'auto', description : 'JSON support')
1616
option('keyutils', type: 'feature', value: 'auto', description: 'keyutils support')
17-
option('liburing', type : 'feature', value: 'auto', description : 'liburing support')
17+
option('liburing', type : 'feature', value: 'disabled', description : 'liburing support')

0 commit comments

Comments
 (0)