tree: fixup coredump during nvme discover

hreinecke · hreinecke · commit cd5ac30b3eae · 2022-03-16T11:40:55.000+01:00
nvme_free_ctrl() expects the 'trsvcid' string to be dynamically
allocated; just calling 'stringify' will cause a coredump on exit.

Signed-off-by: Hannes Reinecke &lt;hare@suse.de&gt;
diff --git a/src/nvme/tree.c b/src/nvme/tree.c
@@ -941,7 +941,7 @@ static void discovery_trsvcid(nvme_ctrl_t c)
 			c->trsvcid = strdup(__stringify(NVME_DISC_IP_PORT));
 		} else {
 			/* Default port for NVMe/TCP io controllers */
-			c->trsvcid = __stringify(NVME_RDMA_IP_PORT);
+			c->trsvcid = strdup(__stringify(NVME_RDMA_IP_PORT));
 		}
 	} else if (!strcmp(c->transport, "rdma")) {
 		/* Default port for NVMe/RDMA controllers */

Original file line number	Diff line number	Diff line change
`@@ -941,7 +941,7 @@ static void discovery_trsvcid(nvme_ctrl_t c)`
`941`	`941`	`c->trsvcid = strdup(__stringify(NVME_DISC_IP_PORT));`
`942`	`942`	`} else {`
`943`	`943`	`/* Default port for NVMe/TCP io controllers */`
`944`		`- c->trsvcid = __stringify(NVME_RDMA_IP_PORT);`
	`944`	`+ c->trsvcid = strdup(__stringify(NVME_RDMA_IP_PORT));`
`945`	`945`	`}`
`946`	`946`	`} else if (!strcmp(c->transport, "rdma")) {`
`947`	`947`	`/* Default port for NVMe/RDMA controllers */`