Skip to content

Commit c95ae8a

Browse files
committed
fabrics: Update prototype documentation
Fill out missing bits in the function prototyp documentation. Signed-off-by: Hannes Reinecke <[email protected]>
1 parent b97d8b3 commit c95ae8a

1 file changed

Lines changed: 36 additions & 24 deletions

File tree

src/nvme/fabrics.h

Lines changed: 36 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -111,34 +111,46 @@ const char *nvmf_treq_str(__u8 treq);
111111
const char *nvmf_eflags_str(__u16 eflags);
112112

113113
/**
114-
* nvmf_sectype_str() -
115-
* @sectype:
114+
* nvmf_sectype_str() - Decode SECTYPE field
115+
* @sectype: value to be decoded
116116
*
117-
* Return:
117+
* Decode the SECTYPE field in the discovery log page
118+
* entry.
119+
*
120+
* Return: decoded string
118121
*/
119122
const char *nvmf_sectype_str(__u8 sectype);
120123

121124
/**
122-
* nvmf_prtype_str() -
123-
* @prtype:
125+
* nvmf_prtype_str() - Decode RDMA Provider type field
126+
* @prtype: value to be decoded
124127
*
125-
* Return:
128+
* Decode the RDMA Provider type field in the discovery
129+
* log page entry.
130+
*
131+
* Return: decoded string
126132
*/
127133
const char *nvmf_prtype_str(__u8 prtype);
128134

129135
/**
130-
* nvmf_qptype_str() -
131-
* @qptype:
136+
* nvmf_qptype_str() - Decode RDMA QP Service type field
137+
* @qptype: value to be decoded
132138
*
133-
* Return:
139+
* Decode the RDMA QP Service type field in the discovery log page
140+
* entry.
141+
*
142+
* Return: decoded string
134143
*/
135144
const char *nvmf_qptype_str(__u8 qptype);
136145

137146
/**
138-
* nvmf_cms_str() -
139-
* @cms:
147+
* nvmf_cms_str() - Decode RDMA connection management service field
148+
* @cms: value to be decoded
140149
*
141-
* Return:
150+
* Decode the RDMA connection management service field in the discovery
151+
* log page entry.
152+
*
153+
* Return: decoded string
142154
*/
143155
const char *nvmf_cms_str(__u8 cms);
144156

@@ -166,12 +178,12 @@ int nvmf_add_ctrl(nvme_host_t h, nvme_ctrl_t c,
166178
const struct nvme_fabrics_config *cfg);
167179

168180
/**
169-
* nvmf_get_discovery_log() -
170-
* @c:
171-
* @logp:
172-
* @max_retries:
181+
* nvmf_get_discovery_log() - Return the discovery log page
182+
* @c: Discover controller to use
183+
* @logp: Pointer to the log page to be returned
184+
* @max_retries: maximum number of log page entries to be returned
173185
*
174-
* Return:
186+
* Return: 0 on success; on failure -1 is returned and errno is set
175187
*/
176188
int nvmf_get_discovery_log(nvme_ctrl_t c, struct nvmf_discovery_log **logp,
177189
int max_retries);
@@ -200,21 +212,21 @@ char *nvmf_hostnqn_from_file();
200212
char *nvmf_hostid_from_file();
201213

202214
/**
203-
* nvmf_connect_disc_entry() -
204-
* @h:
205-
* @e:
206-
* @defcfg:
207-
* @discover:
215+
* nvmf_connect_disc_entry() - Connect controller based on the discovery log page entry
216+
* @h: Host to which the controller should be connected
217+
* @e: Discovery log page entry
218+
* @defcfg: Default configurationn to be used for the new controller
219+
* @discover: Set to 'true' if the new controller is a discovery controller
208220
*
209-
* Return: An
221+
* Return: Pointer to the new controller
210222
*/
211223
nvme_ctrl_t nvmf_connect_disc_entry(nvme_host_t h,
212224
struct nvmf_disc_log_entry *e,
213225
const struct nvme_fabrics_config *defcfg, bool *discover);
214226

215227
/**
216228
* nvme_chomp() - Strip trailing white space
217-
* &s: String to strip
229+
* @s: String to strip
218230
* @l: Maximum length of string
219231
*/
220232
static inline void nvme_chomp(char *s, int l)

0 commit comments

Comments
 (0)