Skip to content

Commit 85b53eb

Browse files
committed
fabrics: Free old traddr in nvmf_add_ctrl
We need to free the old traddr and not the newly translated traddr. Signed-off-by: Daniel Wagner <[email protected]>
1 parent 3dc8554 commit 85b53eb

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

src/nvme/fabrics.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -536,15 +536,15 @@ int nvmf_add_ctrl(nvme_host_t h, nvme_ctrl_t c,
536536
cfg = merge_config(c, cfg);
537537
nvme_ctrl_set_discovered(c, true);
538538
if (traddr_is_hostname(h->r, c)) {
539-
const char *traddr = c->traddr;
539+
char *traddr = c->traddr;
540540

541541
c->traddr = hostname2traddr(h->r, traddr);
542542
if (!c->traddr) {
543-
c->traddr = (char *)traddr;
543+
c->traddr = traddr;
544544
errno = ENVME_CONNECT_TRADDR;
545545
return -1;
546546
}
547-
free(c->traddr);
547+
free(traddr);
548548
}
549549

550550
ret = build_options(h, c, &argstr);

0 commit comments

Comments
 (0)