Skip to content

Commit 73c397c

Browse files
author
Martin Belanger
committed
fabrics: Invoke nvmf_dim() with provided tas argument
Looks like a copy-paste issue. One of the arguments to nvmf_register_ctrl() is "tas" (i.e. the DIM Task). This argument should be passed to the nvmf_dim() API, but instead a fixed value of NVMF_DIM_TAS_REGISTER was passed. The "tas" field specifies whether to perform a "registration", "deregistration", or a "registration update". Signed-off-by: Martin Belanger <[email protected]>
1 parent 851f186 commit 73c397c

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

src/nvme/fabrics.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1306,6 +1306,5 @@ int nvmf_register_ctrl(nvme_ctrl_t c, enum nvmf_dim_tas tas, __u32 *result)
13061306
* to retrieve the source address from the socket and use that
13071307
* as the registration address.
13081308
*/
1309-
return nvmf_dim(c, NVMF_DIM_TAS_REGISTER, NVMF_TRTYPE_TCP,
1310-
nvme_get_adrfam(c), "", NULL, result);
1309+
return nvmf_dim(c, tas, NVMF_TRTYPE_TCP, nvme_get_adrfam(c), "", NULL, result);
13111310
}

0 commit comments

Comments
 (0)