tree: always set the host key

The current logic will not set the host secret to the controller when
the sysfs value and the value from the host object are identically.

Thus, if the controller has a host key us this one and add it to
controller, if missing try to use the one from the host object.

Signed-off-by: Daniel Wagner <[email protected]>

Author: igaw

src/nvme/tree.c

@@ -1984,11 +1984,12 @@ static void nvme_read_sysfs_dhchap(nvme_root_t r, nvme_ctrl_t c)
 	char *host_key, *ctrl_key;
 
 	host_key = nvme_get_ctrl_attr(c, "dhchap_secret");
-	if (host_key && c->s && c->s->h && c->s->h->dhchap_key &&
-			(!strcmp(c->s->h->dhchap_key, host_key) ||
-			 !strcmp("none", host_key))) {
+	if (host_key && !strcmp(host_key, "none")) {
 		free(host_key);
-		host_key = NULL;
+		if (c->s && c->s->h)
+			host_key = strdup(c->s->h->dhchap_key);
+		else
+			host_key = NULL;
 	}
 	if (host_key) {
 		nvme_ctrl_set_dhchap_host_key(c, NULL);