Skip to content

Commit 629b045

Browse files
minwooimigaw
authored andcommitted
types: add opcode field to error log page (TP4113)
Add support for opcode field in error information log page based on TP 4113. It is easy to identify which command is associated with the error. Signed-off-by: Minwoo Im <[email protected]>
1 parent 2f8d484 commit 629b045

1 file changed

Lines changed: 12 additions & 4 deletions

File tree

src/nvme/types.h

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2515,12 +2515,18 @@ struct nvme_supported_log_pages {
25152515
* related, this field shall be cleared to %0h. If the error
25162516
* is transport related, this field shall be set to the type
25172517
* of the transport - see &enum nvme_trtype.
2518-
* @rsvd: Reserved
2518+
* @csi: Command Set Indicator: This field contains command set
2519+
* indicator for the command that the error is associated
2520+
* with.
2521+
* @opcode: Opcode: This field contains opcode for the command that
2522+
* the error is associated with.
25192523
* @cs: Command Specific Information: This field contains command
25202524
* specific information. If used, the command definition
25212525
* specifies the information returned.
25222526
* @trtype_spec_info: Transport Type Specific Information
2523-
* @rsvd2: Reserved
2527+
* @rsvd: Reserved: [62:42]
2528+
* @log_page_version: This field shall be set to 1h. If set, @csi and @opcode
2529+
* will have valid values.
25242530
*/
25252531
struct nvme_error_log_page {
25262532
__le64 error_count;
@@ -2532,10 +2538,12 @@ struct nvme_error_log_page {
25322538
__le32 nsid;
25332539
__u8 vs;
25342540
__u8 trtype;
2535-
__u8 rsvd[2];
2541+
__u8 csi;
2542+
__u8 opcode;
25362543
__le64 cs;
25372544
__le16 trtype_spec_info;
2538-
__u8 rsvd2[22];
2545+
__u8 rsvd[21];
2546+
__u8 log_page_version;
25392547
};
25402548

25412549
enum nvme_err_pel {

0 commit comments

Comments
 (0)