Skip to content

Commit 4308f42

Browse files
committed
tree: add debugging messages during scanning
Add some debugging messages during scanning to aid debugging. Signed-off-by: Hannes Reinecke <[email protected]>
1 parent db8b5ce commit 4308f42

1 file changed

Lines changed: 14 additions & 3 deletions

File tree

src/nvme/tree.c

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ static int nvme_scan_subsystem(nvme_root_t r, const char *name,
4444
nvme_scan_filter_t f);
4545
static int nvme_ctrl_scan_namespace(nvme_root_t r, struct nvme_ctrl *c,
4646
char *name);
47-
static int nvme_ctrl_scan_path(struct nvme_ctrl *c, char *name);
47+
static int nvme_ctrl_scan_path(nvme_root_t r, struct nvme_ctrl *c, char *name);
4848

4949
static inline void nvme_free_dirents(struct dirent **d, int i)
5050
{
@@ -97,6 +97,8 @@ int nvme_scan_topology(struct nvme_root *r, nvme_scan_filter_t f)
9797
continue;
9898
}
9999
if ((f) && !f(c->s)) {
100+
nvme_msg(r, LOG_DEBUG, "filter out controller %s\n",
101+
ctrls[i]->d_name);
100102
nvme_free_ctrl(c);
101103
}
102104
}
@@ -508,6 +510,7 @@ static int nvme_scan_subsystem(struct nvme_root *r, const char *name,
508510
nvme_host_t h = NULL;
509511
int ret;
510512

513+
nvme_msg(r, LOG_DEBUG, "scan subsystem %s\n", name);
511514
ret = asprintf(&path, "%s/%s", nvme_subsys_sysfs_dir, name);
512515
if (ret < 0)
513516
return ret;
@@ -557,6 +560,7 @@ static int nvme_scan_subsystem(struct nvme_root *r, const char *name,
557560
nvme_subsystem_scan_namespaces(r, s);
558561

559562
if (f && !f(s)) {
563+
nvme_msg(r, LOG_DEBUG, "filter out subsystem %s\n", name);
560564
__nvme_free_subsystem(s);
561565
return -1;
562566
}
@@ -618,12 +622,14 @@ static void nvme_subsystem_set_path_ns(nvme_subsystem_t s, nvme_path_t p)
618622
}
619623
}
620624

621-
static int nvme_ctrl_scan_path(struct nvme_ctrl *c, char *name)
625+
static int nvme_ctrl_scan_path(nvme_root_t r, struct nvme_ctrl *c, char *name)
622626
{
623627
struct nvme_path *p;
624628
char *path, *grpid;
625629
int ret;
626630

631+
nvme_msg(r, LOG_DEBUG, "scan controller %s path %s\n",
632+
c->name, name);
627633
if (!c->s) {
628634
errno = ENXIO;
629635
return -1;
@@ -1067,7 +1073,7 @@ static int nvme_ctrl_scan_paths(nvme_root_t r, struct nvme_ctrl *c)
10671073
return ret;
10681074

10691075
for (i = 0; i < ret; i++)
1070-
nvme_ctrl_scan_path(c, paths[i]->d_name);
1076+
nvme_ctrl_scan_path(r, c, paths[i]->d_name);
10711077

10721078
nvme_free_dirents(paths, i);
10731079
return 0;
@@ -1325,6 +1331,7 @@ nvme_ctrl_t nvme_scan_ctrl(nvme_root_t r, const char *name)
13251331
char *hostnqn, *hostid, *subsysnqn, *subsysname;
13261332
int ret;
13271333

1334+
nvme_msg(r, LOG_DEBUG, "scan controller %s\n", name);
13281335
ret = asprintf(&path, "%s/%s", nvme_ctrl_sysfs_dir, name);
13291336
if (ret < 0) {
13301337
errno = ENOMEM;
@@ -1820,6 +1827,8 @@ static int nvme_ctrl_scan_namespace(nvme_root_t r, struct nvme_ctrl *c,
18201827
{
18211828
struct nvme_ns *n;
18221829

1830+
nvme_msg(r, LOG_DEBUG, "scan controller %s namespace %s\n",
1831+
c->name, name);
18231832
if (!c->s) {
18241833
nvme_msg(r, LOG_DEBUG, "no subsystem for %s\n", name);
18251834
errno = EINVAL;
@@ -1868,6 +1877,8 @@ static int nvme_subsystem_scan_namespace(nvme_root_t r, nvme_subsystem_t s,
18681877
{
18691878
struct nvme_ns *n;
18701879

1880+
nvme_msg(r, LOG_DEBUG, "scan subsystem %s namespace %s\n",
1881+
s->name, name);
18711882
n = __nvme_scan_namespace(s->sysfs_dir, name);
18721883
if (!n) {
18731884
nvme_msg(r, LOG_DEBUG, "failed to scan namespace %s\n", name);

0 commit comments

Comments
 (0)