Skip to content

Commit 403e843

Browse files
authored
Merge pull request #545 from jinliangw/rename_tmp
mi: rename tmp variable inside nvme_mi_admin_get_log
2 parents 749922a + 9ac9f8a commit 403e843

1 file changed

Lines changed: 7 additions & 6 deletions

File tree

src/nvme/mi.c

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -839,7 +839,7 @@ static int __nvme_mi_admin_get_log(nvme_mi_ctrl_t ctrl,
839839

840840
int nvme_mi_admin_get_log(nvme_mi_ctrl_t ctrl, struct nvme_get_log_args *args)
841841
{
842-
const size_t xfer_size = 4096;
842+
const size_t max_xfer_size = 4096;
843843
off_t xfer_offset;
844844
int rc = 0;
845845

@@ -849,25 +849,26 @@ int nvme_mi_admin_get_log(nvme_mi_ctrl_t ctrl, struct nvme_get_log_args *args)
849849
}
850850

851851
for (xfer_offset = 0; xfer_offset < args->len;) {
852-
size_t tmp, cur_xfer_size = xfer_size;
852+
size_t xfered_size, cur_xfer_size = max_xfer_size;
853853
bool final;
854854

855855
if (xfer_offset + cur_xfer_size > args->len)
856856
cur_xfer_size = args->len - xfer_offset;
857857

858-
tmp = cur_xfer_size;
858+
xfered_size = cur_xfer_size;
859859

860860
final = xfer_offset + cur_xfer_size >= args->len;
861861

862+
/* xfered_size is used as both input and output parameter */
862863
rc = __nvme_mi_admin_get_log(ctrl, args, xfer_offset,
863-
&tmp, final);
864+
&xfered_size, final);
864865
if (rc)
865866
break;
866867

867-
xfer_offset += tmp;
868+
xfer_offset += xfered_size;
868869
/* if we returned less data than expected, consider that
869870
* the end of the log page */
870-
if (tmp != cur_xfer_size)
871+
if (xfered_size != cur_xfer_size)
871872
break;
872873
}
873874

0 commit comments

Comments
 (0)