Skip to content

Commit 0930a59

Browse files
committed
build: don't append dev0 for tag builds
src/meson.build:51:10: ERROR: library keyword argument "version" Invalid Shared library version "1.12.dev0". Must be of the form X.Y.Z where all three are numbers. Y and Z are optional. Signed-off-by: Daniel Wagner <[email protected]>
1 parent b5ee8ba commit 0930a59

1 file changed

Lines changed: 8 additions & 1 deletion

File tree

.github/workflows/release-python.yml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,14 @@ jobs:
7575
TAG=$(git describe --tags --abbrev=0)
7676
REV=$(git rev-list "$TAG"..HEAD --count)
7777
BASE_VERSION="${TAG#v}"
78-
VERSION="${BASE_VERSION}.dev${REV}"
78+
79+
# Check if REV is 0, and don't append '.dev' if so
80+
if [ "$REV" -eq 0 ]; then
81+
VERSION="${BASE_VERSION}"
82+
else
83+
VERSION="${BASE_VERSION}.dev${REV}"
84+
fi
85+
7986
echo "dev_version=$VERSION" >> $GITHUB_OUTPUT
8087
echo "Computed dev version: $VERSION"
8188

0 commit comments

Comments
 (0)