Skip to content

Commit 055639d

Browse files
committed
tree: rename controller 'dhchap_key' to 'dhchap_ctrl_key'
To differentiate between 'host' and 'controller' keys within the controller structure. Signed-off-by: Hannes Reinecke <[email protected]>
1 parent 32b7684 commit 055639d

3 files changed

Lines changed: 13 additions & 13 deletions

File tree

src/nvme/fabrics.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -619,8 +619,8 @@ int nvmf_add_ctrl(nvme_host_t h, nvme_ctrl_t c,
619619
* in @cfg, so ensure to update @c with the correct
620620
* controller key.
621621
*/
622-
if (fc->dhchap_key)
623-
nvme_ctrl_set_dhchap_key(c, fc->dhchap_key);
622+
if (fc->dhchap_ctrl_key)
623+
nvme_ctrl_set_dhchap_key(c, fc->dhchap_ctrl_key);
624624
}
625625

626626
}

src/nvme/private.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ struct nvme_ctrl {
8282
char *subsysnqn;
8383
char *traddr;
8484
char *trsvcid;
85-
char *dhchap_key;
85+
char *dhchap_ctrl_key;
8686
char *cntrltype;
8787
char *dctype;
8888
bool discovery_ctrl;

src/nvme/tree.c

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -812,17 +812,17 @@ struct nvme_fabrics_config *nvme_ctrl_get_config(nvme_ctrl_t c)
812812

813813
const char *nvme_ctrl_get_dhchap_key(nvme_ctrl_t c)
814814
{
815-
return c->dhchap_key;
815+
return c->dhchap_ctrl_key;
816816
}
817817

818818
void nvme_ctrl_set_dhchap_key(nvme_ctrl_t c, const char *key)
819819
{
820-
if (c->dhchap_key) {
821-
free(c->dhchap_key);
822-
c->dhchap_key = NULL;
820+
if (c->dhchap_ctrl_key) {
821+
free(c->dhchap_ctrl_key);
822+
c->dhchap_ctrl_key = NULL;
823823
}
824824
if (key)
825-
c->dhchap_key = strdup(key);
825+
c->dhchap_ctrl_key = strdup(key);
826826
}
827827

828828
void nvme_ctrl_set_discovered(nvme_ctrl_t c, bool discovered)
@@ -897,7 +897,7 @@ void nvme_deconfigure_ctrl(nvme_ctrl_t c)
897897
FREE_CTRL_ATTR(c->queue_count);
898898
FREE_CTRL_ATTR(c->serial);
899899
FREE_CTRL_ATTR(c->sqsize);
900-
FREE_CTRL_ATTR(c->dhchap_key);
900+
FREE_CTRL_ATTR(c->dhchap_ctrl_key);
901901
FREE_CTRL_ATTR(c->address);
902902
FREE_CTRL_ATTR(c->dctype);
903903
FREE_CTRL_ATTR(c->cntrltype);
@@ -1166,10 +1166,10 @@ static int nvme_configure_ctrl(nvme_root_t r, nvme_ctrl_t c, const char *path,
11661166
c->queue_count = nvme_get_ctrl_attr(c, "queue_count");
11671167
c->serial = nvme_get_ctrl_attr(c, "serial");
11681168
c->sqsize = nvme_get_ctrl_attr(c, "sqsize");
1169-
c->dhchap_key = nvme_get_ctrl_attr(c, "dhchap_ctrl_secret");
1170-
if (c->dhchap_key && !strcmp(c->dhchap_key, "none")) {
1171-
free(c->dhchap_key);
1172-
c->dhchap_key = NULL;
1169+
c->dhchap_ctrl_key = nvme_get_ctrl_attr(c, "dhchap_ctrl_secret");
1170+
if (c->dhchap_ctrl_key && !strcmp(c->dhchap_ctrl_key, "none")) {
1171+
free(c->dhchap_ctrl_key);
1172+
c->dhchap_ctrl_key = NULL;
11731173
}
11741174
c->cntrltype = nvme_get_ctrl_attr(c, "cntrltype");
11751175
c->dctype = nvme_get_ctrl_attr(c, "dctype");

0 commit comments

Comments
 (0)