Skip to content

Commit 0235025

Browse files
Martin Belangerigaw
authored andcommitted
python: Remove redundant host.set_key() method
I just found out that the DHCHAP Key can be set as a property (e.g. host.dhchap_key = "THE-KEY"). So, we can remove the set_key() method that was added a few days ago. Signed-off-by: Martin Belanger <[email protected]>
1 parent 2443364 commit 0235025

1 file changed

Lines changed: 0 additions & 13 deletions

File tree

libnvme/nvme.i

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -463,15 +463,6 @@ struct nvme_ns {
463463
@return: None"
464464
%enddef
465465

466-
%define SET_KEY_DOCSTRING
467-
"@brief Set or Clear Host's DHCHAP Key
468-
469-
@param key: A DHCHAP key, or None to clear the key.
470-
@type key: str|None
471-
472-
@return: None"
473-
%enddef
474-
475466
%pythonappend nvme_host::nvme_host(struct nvme_root *r,
476467
const char *hostnqn,
477468
const char *hostid,
@@ -499,10 +490,6 @@ struct nvme_ns {
499490
nvme_host_set_hostsymname($self, hostsymname);
500491
}
501492

502-
%feature("autodoc", SET_KEY_DOCSTRING) set_key;
503-
void set_key(const char *key) {
504-
nvme_host_set_dhchap_key($self, key);
505-
}
506493
PyObject* __str__() {
507494
return PyUnicode_FromFormat("nvme.host(%s,%s)", STR_OR_NONE($self->hostnqn), STR_OR_NONE($self->hostid));
508495
}

0 commit comments

Comments
 (0)